Sign upLogin

EscolaLMS/topic-types

View on GitHub
Star

Showing 313 of 313 total issues

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::table('topic_richtexts', function (Blueprint $table) {
            $table->bigInteger('length')->nullable();
        });
Severity: Minor
Found in database/migrations/2023_07_18_075557_add_length_field_to_topic_richtexts_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::table('topic_videos', function (Blueprint $table) {
            $table->bigInteger('length')->nullable();
        });
Severity: Minor
Found in database/migrations/2023_07_18_082455_add_length_column_to_topic_videos_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\Courses\Facades\Topic' in method 'boot'.
Open

        Topic::registerContentClasses([
            Audio::class,
            Video::class,
            Image::class,
            RichText::class,
Severity: Minor
Found in src/EscolaLmsTopicTypesServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\HeadlessH5P\Repositories\H5PContentRepository' in method 'register'.
Open

        H5PContentRepository::extendQueryJoin(
            fn () => [['topic_h5ps.value', 'hh5p_contents.id']],
            'topic_h5ps'
        );
Severity: Minor
Found in src/EscolaLmsTopicTypesServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'convertFilePathByHttp'.
Open

                Storage::delete($destination . '.' . $ext[1]);
Severity: Minor
Found in src/Helpers/Markdown.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$request'.
Open

    public function toArray($request)
Severity: Minor
Found in src/Http/Resources/TopicType/Client/VideoResource.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'toArray'.
Open

            'url' => $this->resource->value ? Storage::url($this->resource->value) : null,
Severity: Minor
Found in src/Http/Resources/TopicType/Client/VideoResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$request'.
Open

    public function toArray($request)
Severity: Minor
Found in src/Http/Resources/TopicType/Export/Cmi5AuResource.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\EscolaLms\TopicTypes\Facades\Path' in method 'toArray'.
Open

            'value' => Path::sanitizePathForExport(Markdown::getImagesPathsWithoutImageApi($this->resource->value)),
Severity: Minor
Found in src/Http/Resources/TopicType/Export/RichTextResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using EscolaLms\TopicTypes\Database\Factories\FakerMarkdownProvider\count() function in do loops.
Open

        do {
            $parts[] = self::markdownH1();
            if (self::randomDigit() > 3) {
                $parts[] = self::markdownP();
            }
Severity: Minor
Found in database/factories/FakerMarkdownProvider/FakerProvider.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Only one argument is allowed per line in a multi-line function call
Open

            Storage::putFileAs($path, new File(realpath(__DIR__.'/../mocks/1.pdf'), $filename);
Severity: Minor
Found in database/factories/TopicResourceFactory.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            fn () => [['topic_h5ps.value', 'hh5p_contents.id']],
Severity: Minor
Found in src/EscolaLmsTopicTypesServiceProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

                    str_contains($filepath, 'storage') => $results[] = $this->convertFilePathByStorage($filepath, $destination),
Severity: Minor
Found in src/Helpers/Markdown.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

                DB::Connection() instanceof PostgresConnection ? 'hh5p_contents.parameters::jsonb' : 'hh5p_contents.parameters',
Severity: Minor
Found in src/EscolaLmsTopicTypesServiceProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

            'content' => isset($this->resource->value) ? app(HeadlessH5PServiceContract::class)->getContentSettings($this->resource->value) : null,
Severity: Minor
Found in src/Http/Resources/TopicType/Admin/H5PResource.php by phpcodesniffer

Line exceeds 120 characters; contains 139 characters
Open

            return isset($lengthKey['length_key']) ? count(Arr::get($parameters, $lengthKey['length_key'])) : $lengthKey['default_length'];
Severity: Minor
Found in src/Models/TopicContent/H5P.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

        $destination = sprintf('course/%d/topic/%d/%s/%s', $course->id, $topic->id, $this->getStoragePathFinalSegment(), $basename);
Severity: Minor
Found in src/Models/TopicContent/AbstractTopicContent.php by phpcodesniffer

Line exceeds 120 characters; contains 142 characters
Open

                    str_contains($filepath, 'http') => $results[] = $this->convertFilePathByHttp($destinationPrefix, $filepath, $destination),
Severity: Minor
Found in src/Helpers/Markdown.php by phpcodesniffer

Line exceeds 120 characters; contains 158 characters
Open

                    str_contains($filepath, 'api/images/img') => $results[] = $this->convertFilePathByApiPattern($destinationPrefix, $filepath, $destination),
Severity: Minor
Found in src/Helpers/Markdown.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

            'content' => isset($this->resource->value) ? app(HeadlessH5PServiceContract::class)->getContentSettings($this->resource->value) : null,
Severity: Minor
Found in src/Http/Resources/TopicType/Client/H5PResource.php by phpcodesniffer
Severity
Category
Status
Source
Language