FabrizioBrancati/BFKit-Swift

View on GitHub
Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift

Summary

Maintainability
C
7 hrs
Test Coverage

File UIDevice+Extensions.swift has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation
import UIKit

// MARK: - Global variables

Severity: Minor
Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift - About 2 hrs to fix

    Function saveAPNSIdentifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        static func saveAPNSIdentifier(_ uniqueIdentifier: Any, completion: @escaping (_ isValid: Bool, _ needsUpdate: Bool, _ oldUUID: String?, _ newUUID: String) -> Void) {
            var newUUID: String = ""
            var oldUUID: String?
            var isValid = false, needsUpdate = false
            
    Severity: Minor
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static func freeDiskSpace() -> NSNumber {
            do {
                let attributes = try FileManager.default.attributesOfFileSystem(forPath: NSHomeDirectory())
                return attributes[.systemFreeSize] as? NSNumber ?? NSNumber(value: 0.0)
            } catch {
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 1 other location - About 1 hr to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 389..396

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static func totalDiskSpace() -> NSNumber {
            do {
                let attributes = try FileManager.default.attributesOfFileSystem(forPath: NSHomeDirectory())
                return attributes[.systemSize] as? NSNumber ?? NSNumber(value: 0.0)
            } catch {
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 1 other location - About 1 hr to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 401..408

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    public func osVersionLessThanOrEqual(_ version: String) -> Bool {
        UIDevice.current.systemVersion.compare(version, options: .numeric) != .orderedDescending
    }
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 4 other locations - About 30 mins to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 43..45
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 51..53
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 59..61
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 67..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    public func osVersionLessThan(_ version: String) -> Bool {
        UIDevice.current.systemVersion.compare(version, options: .numeric) == .orderedAscending
    }
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 4 other locations - About 30 mins to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 43..45
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 51..53
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 59..61
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    public func osVersionEqual(_ version: String) -> Bool {
        UIDevice.current.systemVersion.compare(version, options: .numeric) == .orderedSame
    }
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 4 other locations - About 30 mins to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 51..53
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 59..61
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 67..69
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    public func osVersionGreaterThanOrEqual(_ version: String) -> Bool {
        UIDevice.current.systemVersion.compare(version, options: .numeric) != .orderedAscending
    }
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 4 other locations - About 30 mins to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 43..45
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 51..53
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 67..69
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    public func osVersionGreaterThan(_ version: String) -> Bool {
        UIDevice.current.systemVersion.compare(version, options: .numeric) == .orderedDescending
    }
    Severity: Major
    Found in Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift and 4 other locations - About 30 mins to fix
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 43..45
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 59..61
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 67..69
    Sources/BFKit/Apple/UIKit/UIDevice+Extensions.swift on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status