Sign upLogin

FabrizioBrancati/Queuer

View on GitHub
Star

Showing 11 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public func pause() {
        queue.isSuspended = true
        
        for operation in queue.operations {
            if let concurrentOperation = operation as? ConcurrentOperation {
Severity: Minor
Found in Sources/Queuer/Queuer.swift and 1 other location - About 35 mins to fix
Sources/Queuer/Queuer.swift on lines 103..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public func resume() {
        queue.isSuspended = false
        
        for operation in queue.operations {
            if let concurrentOperation = operation as? ConcurrentOperation {
Severity: Minor
Found in Sources/Queuer/Queuer.swift and 1 other location - About 35 mins to fix
Sources/Queuer/Queuer.swift on lines 92..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (ConcurrentOperationTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/ConcurrentOperationTests+XCTest.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (QueuerTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/QueuerTests+XCTest.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (SemaphoreTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/SemaphoreTests+XCTest.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

let package = Package(
Severity: Minor
Found in Package.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (SynchronousOperationTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/SynchronousOperationTests+XCTest.swift by swiftlint

Header comments should be consistent with project patterns.
Open

// swift-tools-version:5.0
Severity: Minor
Found in Package.swift by swiftlint

Type body should span 200 lines or less excluding comments and whitespace: currently spans 214 lines
Open

internal class QueuerTests: XCTestCase {
Severity: Minor
Found in Tests/QueuerTests/QueuerTests.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (OperationStateTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/OperationStateTests+XCTest.swift by swiftlint

All declarations should specify Access Control Level keywords explicitly.
Open

    static var allTests: [(String, (SchedulerTests) -> () throws -> Void)] {
Severity: Minor
Found in Tests/QueuerTests/SchedulerTests+XCTest.swift by swiftlint
Severity
Category
Status
Source
Language