FlameCore/Webtools

View on GitHub

Showing 9 of 9 total issues

HttpClient has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class HttpClient
{
    const ENCODING_ALL = '';
    const ENCODING_GZIP = 'gzip';
    const ENCODING_DEFLATE = 'deflate';
Severity: Minor
Found in lib/HttpClient.php - About 2 hrs to fix

    Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute($url, array $headers = array())
        {
            curl_setopt($this->handle, CURLOPT_URL, $url);
    
            curl_setopt($this->handle, CURLOPT_USERAGENT, $this->useragent);
    Severity: Minor
    Found in lib/HttpClient.php - About 1 hr to fix

      Function getImages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getImages()
          {
              $images = array();
      
              $nodes = $this->html->findTags('img');
      Severity: Minor
      Found in lib/WebpageAnalyzer.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toHtml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toHtml($data)
          {
              if (!is_object($data) && !is_array($data)) {
                  throw new \InvalidArgumentException('The $data parameter takes only an object or an array.');
              }
      Severity: Minor
      Found in lib/OEmbed.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseHeaders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseHeaders($rawHeaders)
          {
              $headers = array();
      
              $lines = explode("\r\n", preg_replace('/\x0D\x0A[\x09\x20]+/', ' ', $rawHeaders));
      Severity: Minor
      Found in lib/HttpClient.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function openFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function openFile($file)
          {
              if (is_resource($file)) {
                  if (get_resource_type($file) !== 'stream') {
                      throw new \InvalidArgumentException('The given resource is not a file handle.');
      Severity: Minor
      Found in lib/HttpClient.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function discover has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function discover($url, array $args = [])
          {
              $url = trim($url);
              $html = HtmlExplorer::fromWeb($url, $this->http);
      
      
      Severity: Minor
      Found in lib/OEmbed.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute($url, array $headers = array())
          {
              curl_setopt($this->handle, CURLOPT_URL, $url);
      
              curl_setopt($this->handle, CURLOPT_USERAGENT, $this->useragent);
      Severity: Minor
      Found in lib/HttpClient.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this->render($type, $data);
      Severity: Major
      Found in lib/OEmbed.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language