Flow2Lab/EventSourcing

View on GitHub

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function onEventQueueingSuccess(DomainEvent $event, EventHandlerInterface $eventHandler)
    {
        $eventType = new ObjectName($event);
        $eventHandlerType = new ObjectName($eventHandler);
        $additionalData = [
Severity: Major
Found in Classes/Flow2Lab/EventSourcing/Auditing/EventLogger.php and 1 other location - About 1 hr to fix
Classes/Flow2Lab/EventSourcing/Auditing/EventLogger.php on lines 34..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function onEventHandlingSuccess(DomainEvent $event, EventHandlerInterface $eventHandler)
    {
        $eventType = new ObjectName($event);
        $eventHandlerType = new ObjectName($eventHandler);
        $additionalData = [
Severity: Major
Found in Classes/Flow2Lab/EventSourcing/Auditing/EventLogger.php and 1 other location - About 1 hr to fix
Classes/Flow2Lab/EventSourcing/Auditing/EventLogger.php on lines 78..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function load($eventStream)
    {
        try {
            $feed = $this->eventStore->openStreamFeed($eventStream, EntryEmbedMode::RICH());
        } catch (StreamNotFoundException $e) {
Severity: Minor
Found in Classes/Flow2Lab/EventSourcing/Store/Backend/EventStoreBackend.php - About 1 hr to fix

    Function load has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function load($eventStream)
        {
            try {
                $feed = $this->eventStore->openStreamFeed($eventStream, EntryEmbedMode::RICH());
            } catch (StreamNotFoundException $e) {
    Severity: Minor
    Found in Classes/Flow2Lab/EventSourcing/Store/Backend/EventStoreBackend.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function replayAllProjectionsCommand has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function replayAllProjectionsCommand()
        {
            $projectorClassNames = $this->reflectionService->getAllImplementationClassNamesForInterface(ProjectorInterface::class);
            // todo: find a better way of doing this
    
    

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle(Command $command)
        {
            $commandHandled = FALSE;
    
            foreach ($this->commandHandlers as $commandHandler) {
    Severity: Minor
    Found in Classes/Flow2Lab/EventSourcing/Command/Bus/InternalCommandBus.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function publish has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function publish(DomainEvent $event)
        {
            foreach ($this->eventSubscribers as $eventHandler) {
                if ($eventHandler->canHandleEvent($event)) {
                    if ($eventHandler instanceof ImmediateEventHandlerInterface) {
    Severity: Minor
    Found in Classes/Flow2Lab/EventSourcing/Event/Bus/InternalEventBus.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function unserialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function unserialize($serializedMessage)
        {
            if (is_array($serializedMessage) === FALSE) {
                throw new \InvalidArgumentException('The ArraySerializer can only unserialize arrays.', 1427369045);
            }
    Severity: Minor
    Found in Classes/Flow2Lab/EventSourcing/Serializer/ArraySerializer.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function apply(DomainEvent $event)
        {
            $applyMethod = $this->getEventApplyMethod($event);
    
            if (method_exists($this, $applyMethod) === TRUE) {
    Severity: Minor
    Found in Classes/Flow2Lab/EventSourcing/EventSourcing.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language