ForestAdmin/forest-express-sequelize

View on GitHub

Showing 52 of 78 total issues

Function HasManyDissociator has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function HasManyDissociator(model, association, options, params, data) {
  const OPERATORS = Operators.getInstance(options);
  const isDelete = Boolean(params.delete);

  this.perform = () => {
Severity: Minor
Found in src/services/has-many-dissociator.js - About 1 hr to fix

    Function perform has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.perform = () => {
        const schema = {
          field: column.fieldName,
          type: new ApimapFieldTypeDetector(column, options).perform(),
          // NOTICE: Necessary only for fields with different field and database
    Severity: Minor
    Found in src/services/apimap-field-builder.js - About 1 hr to fix

      Function removeDuplicateAssociations has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function removeDuplicateAssociations(model, includeList) {
        // Remove duplicates
        includeList.sort((include1, include2) => (include1.as < include2.as ? -1 : 1));
        for (let i = 1; i < includeList.length; i += 1) {
          if (includeList[i - 1].as === includeList[i].as) {
      Severity: Minor
      Found in src/utils/sequelize-compatibility.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeInclude has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function normalizeInclude(model, include) {
        if (include.sequelize) {
          return {
            model: include,
            as: Object
      Severity: Minor
      Found in src/utils/sequelize-compatibility.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function perform has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.perform = () => {
          const associatedIds = _.map(data.data, (value) => value.id);
          return orm.findRecord(model, params.recordId)
            .then((record) => {
              let removeAssociation = false;
      Severity: Minor
      Found in src/services/has-many-dissociator.js - About 1 hr to fix

        Function getGroupByDateFieldFormatedForSQLite has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function getGroupByDateFieldFormatedForSQLite(currentTimeRange) {
            switch (currentTimeRange) {
              case 'day': {
                return options.Sequelize.fn(
                  'STRFTIME',
        Severity: Minor
        Found in src/services/line-stat-getter.js - About 1 hr to fix

          Function normalizeInclude has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function normalizeInclude(model, include) {
            if (include.sequelize) {
              return {
                model: include,
                as: Object
          Severity: Minor
          Found in src/utils/sequelize-compatibility.js - About 1 hr to fix

            Function perform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              this.perform = async () => {
                const { timezone } = params;
                const parentSequelizeOptions = await getSequelizeOptionsForModel(parentModel, user, timezone);
                const childSequelizeOptions = await getSequelizeOptionsForModel(childModel, user, timezone);
            
            
            Severity: Minor
            Found in src/services/leaderboard-stat-getter.js - About 1 hr to fix

              Function QueryBuilder has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function QueryBuilder() {
                this.getIncludes = (modelForIncludes, fieldNamesRequested) => {
                  const includes = [];
              
                  Object.values(modelForIncludes.associations)
              Severity: Minor
              Found in src/services/query-builder.js - About 1 hr to fix

                Function removeDuplicateAssociations has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function removeDuplicateAssociations(model, includeList) {
                  // Remove duplicates
                  includeList.sort((include1, include2) => (include1.as < include2.as ? -1 : 1));
                  for (let i = 1; i < includeList.length; i += 1) {
                    if (includeList[i - 1].as === includeList[i].as) {
                Severity: Minor
                Found in src/utils/sequelize-compatibility.js - About 1 hr to fix

                  Function getIncludes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    this.getIncludes = (modelForIncludes, fieldNamesRequested) => {
                      const includes = [];
                  
                      Object.values(modelForIncludes.associations)
                        .filter((association) => [HAS_ONE, BELONGS_TO].includes(association.associationType))
                  Severity: Minor
                  Found in src/services/query-builder.js - About 1 hr to fix

                    Function getGroupByDateFieldFormatedForMSSQL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      function getGroupByDateFieldFormatedForMSSQL(currentTimeRange) {
                        const groupByDateFieldFormated = `[${groupByDateField.replace('.', '].[')}]`;
                        switch (currentTimeRange) {
                          case 'day':
                            return options.Sequelize.fn(
                    Severity: Minor
                    Found in src/services/line-stat-getter.js - About 1 hr to fix

                      Function getGroupByDateFieldFormatedForMySQL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        function getGroupByDateFieldFormatedForMySQL(currentTimeRange) {
                          const groupByDateFieldFormated = `\`${groupByDateField.replace('.', '`.`')}\``;
                          switch (currentTimeRange) {
                            case 'day':
                              return options.Sequelize.fn(
                      Severity: Minor
                      Found in src/services/line-stat-getter.js - About 1 hr to fix

                        Function perform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          this.perform = async () => {
                            const { filters, timezone } = params;
                            const scopeFilters = await scopeManager.getScopeForUser(user, model.name, true);
                        
                            const queryOptions = new QueryOptions(model, { includeRelations: true });
                        Severity: Minor
                        Found in src/services/line-stat-getter.js - About 1 hr to fix

                          Function PieStatGetter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function PieStatGetter(model, params, options, user) {
                            const needsDateOnlyFormating = isVersionLessThan(options.Sequelize, '4.0.0');
                          
                            const schema = Schemas.schemas[model.name];
                            let associationSplit;
                          Severity: Minor
                          Found in src/services/pie-stat-getter.js - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                          if (field.type === 'Number') {
                                            const value = parseInt(params.search, 10) || 0;
                                            if (value) {
                                              condition = opts.Sequelize.where(column, ' = ', value);
                                              hasExtendedConditions = true;
                          Severity: Major
                          Found in src/services/search-builder.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                          } else if (field.type === 'String') {
                                            condition = getStringExtendedCondition(
                                              modelAssociation.rawAttributes[field.field], params.search, column,
                                            );
                                            hasExtendedConditions = !!condition;
                            Severity: Major
                            Found in src/services/search-builder.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                      if (conditionValue !== null) {
                                        condition[field.field] = conditionValue;
                                        pushCondition(condition, field.field);
                                      }
                              Severity: Major
                              Found in src/services/search-builder.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                          if (params.search.match(REGEX_UUID)) {
                                            condition[field.field] = params.search;
                                            pushCondition(condition, field.field);
                                          }
                                Severity: Major
                                Found in src/services/search-builder.js - About 45 mins to fix

                                  Function ResourcesExporter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function ResourcesExporter(model, options, params, association, user) {
                                  Severity: Minor
                                  Found in src/services/resources-exporter.js - About 35 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language