FrenchYeti/dexcalibur

View on GitHub

Showing 948 of 948 total issues

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    ADD_DOUBLE:{ byte:0xab, instr:"add-double", ope: CONST.LEX.TOKEN.ADD, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    ADD_DOUBLE_2ADDR:{ byte:0xcb, instr:"add-double/2addr", ope: CONST.LEX.TOKEN.ADD, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    REM_INT_2ADDR:{ byte:0xb4, instr:"rem-int/2addr", ope: CONST.LEX.TOKEN.REM, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    NOT_LONG:{ byte:0x7e, instr:"not-long", ope: CONST.LEX.TOKEN.NOT, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    MUL_LONG:{ byte:0x9d, instr:"mul-long", ope: CONST.LEX.TOKEN.MUL, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    MUL_DOUBLE:{ byte:0xad, instr:"mul-double", ope: CONST.LEX.TOKEN.MUL, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    OR_LONG_2ADDR:{ byte:0xc1, instr:"or-long/2addr", ope: CONST.LEX.TOKEN.OR, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    DIV_INT_LIT8:{ byte:0xdb, instr:"div-int/lit8",  ope: CONST.LEX.TOKEN.DIV, parse: MainParser.format_lit16, type: CONST.INSTR_TYPE.MATH,  reftype:ReferenceType.NONE, format:Format.Format22b, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    REM_INT_LIT8:{ byte:0xdc, instr:"rem-int/lit8",  ope: CONST.LEX.TOKEN.REM, parse: MainParser.format_lit16, type: CONST.INSTR_TYPE.MATH,  reftype:ReferenceType.NONE, format:Format.Format22b, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    REM_INT:{ byte:0x94, instr:"rem-int", ope: CONST.LEX.TOKEN.REM, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format23x, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    MUL_LONG_2ADDR:{ byte:0xbd, instr:"mul-long/2addr", ope: CONST.LEX.TOKEN.MUL, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    SHR_LONG_2ADDR:{ byte:0xc4, instr:"shr-long/2addr", ope: CONST.LEX.TOKEN.SHR, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    MUL_DOUBLE_2ADDR:{ byte:0xcd, instr:"mul-double/2addr", ope: CONST.LEX.TOKEN.MUL, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                            this.stack.setLocalSymbol(
                                regV, 
                                DTYPE.IMM_NUMERIC,
                                regX[SYMBOL_OPE[oper.opcode.ope]](regV.getValue(), oper.opcode.byte),
                                `${this.getImmediateValue(regX)}${oper.opcode.ope}${this.getImmediateValue(regV)}`);
Severity: Major
Found in src/SmaliVM.js and 1 other location - About 2 hrs to fix
src/SmaliVM.js on lines 1964..1968

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                this.stack.setLocalSymbol(
                    regV, 
                    DTYPE.IMM_NUMERIC,
                    regX[SYMBOL_OPE[oper.opcode.ope]](regV.getValue(), oper.opcode.byte),
                    `${this.getImmediateValue(regX)}${oper.opcode.ope}${this.getImmediateValue(regV)}`);
Severity: Major
Found in src/SmaliVM.js and 1 other location - About 2 hrs to fix
src/SmaliVM.js on lines 3086..3090

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function merge has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    merge( pDevice){
        for(let i in pDevice){
            switch(i){
                case 'enrolled':
                    if(pDevice.enrolled)
Severity: Major
Found in src/Device.js - About 2 hrs to fix

    Function importManifest has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async importManifest(path){
            let codeAnal = this.context.getAnalyzer();
            let self = this;
            let data = null;
    
    
    Severity: Major
    Found in src/AndroidAppAnalyzer.js - About 2 hrs to fix

      Function toJsonObject has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Class.prototype.toJsonObject = function(filter){
          let obj = new Object(), m=null;
          for(let i in this){
              if(["_","$"].indexOf(i[0])==-1 
                  && (typeof this[i] != 'array')
      Severity: Major
      Found in src/CoreClass.js - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if(data.classes.size > 0){
                    coll = self._db.getIndex("classes");
                    coll.map(function(ref,obj){
                        data.classes.data[ref] = {
                            type: SaveManager.T_CLASS,
        Severity: Major
        Found in inspectors/Saver/SaveManager.js and 2 other locations - About 2 hrs to fix
        inspectors/Saver/SaveManager.js on lines 332..340
        inspectors/Saver/SaveManager.js on lines 342..350

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if(data.methods.size > 0){
                    coll = self._db.getIndex("methods");
                    coll.map(function(ref,obj){
                        data.methods.data[ref] = {
                            type: SaveManager.T_METHOD,
        Severity: Major
        Found in inspectors/Saver/SaveManager.js and 2 other locations - About 2 hrs to fix
        inspectors/Saver/SaveManager.js on lines 332..340
        inspectors/Saver/SaveManager.js on lines 352..360

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language