FrenchYeti/dexcalibur

View on GitHub

Showing 948 of 948 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  readXmlNamespaceEnd(/* header */) {
    /* const line = */ this.readU32();
    /* const commentRef = */ this.readU32();
    /* const prefixRef = */ this.readS32();
    /* const uriRef = */ this.readS32();
Severity: Major
Found in src/libs/BinaryXmlParser.js and 1 other location - About 1 hr to fix
src/libs/BinaryXmlParser.js on lines 374..387

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function invoke has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    invoke( pMethod, pObj, pArgs){
        let opt = null;

        // execute hooks 
        if(this.isHooked(pMethod)){
Severity: Minor
Found in src/SmaliVM.js - About 1 hr to fix

    Function Call has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Call(cfg){
    
        this.$ = STUB_TYPE.CALL;
    
        this.instr = null;
    Severity: Minor
    Found in src/CoreClass.js - About 1 hr to fix

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE:{ 
              byte:0x01, 
              instr:"move", 
              reftype:ReferenceType.NONE, 
              format:Format.Format12x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_FROM16:{ 
              byte:0x02, 
              instr:"move/from16", 
              reftype:ReferenceType.NONE, 
              format:Format.Format22x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_16:{ 
              byte:0x03, 
              instr:"move/16", 
              reftype:ReferenceType.NONE, 
              format:Format.Format32x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_OBJECT:{ 
              byte:0x07, 
              instr:"move-object", 
              reftype:ReferenceType.NONE, 
              format:Format.Format12x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_OBJECT_FROM16:{ 
              byte:0x08, 
              instr:"move-object/from16", 
              reftype: ReferenceType.NONE, 
              format: Format.Format22x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_OBJECT_16:{ 
              byte:0x09, 
              instr:"move-object/16", 
              reftype:ReferenceType.NONE, 
              format:Format.Format32x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_EXCEPTION:{
              byte:0x0d, 
              instr:"move-exception", 
              reftype:ReferenceType.NONE, 
              format:Format.Format11x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          CONST:{ 
              byte:0x14, 
              instr:"const", 
              reftype:ReferenceType.NONE, 
              format:Format.Format31i, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          CONST_16:{ 
              byte:0x13, 
              instr:"const/16", 
              reftype:ReferenceType.NONE, 
              format:Format.Format21s, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_RESULT_OBJECT:{ 
              byte:0x0c,
              instr:"move-result-object", 
              reftype:ReferenceType.NONE, 
              format:Format.Format11x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MONITOR_EXIT:{ 
              byte:0x1e, 
              instr:"monitor-exit", 
              reftype:ReferenceType.NONE, 
              format:Format.Format11x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          CONST_HIGH16:{ 
              byte:0x15, 
              instr:"const/high16", 
              reftype:ReferenceType.NONE, 
              format:Format.Format21ih, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 483..493
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          MOVE_RESULT:{ 
              byte:0x0a, 
              instr:"move-result", 
              reftype:ReferenceType.NONE, 
              format:Format.Format11x, 
      Severity: Major
      Found in src/Opcode.js and 12 other locations - About 1 hr to fix
      src/Opcode.js on lines 385..395
      src/Opcode.js on lines 396..406
      src/Opcode.js on lines 407..417
      src/Opcode.js on lines 451..461
      src/Opcode.js on lines 462..472
      src/Opcode.js on lines 473..482
      src/Opcode.js on lines 505..515
      src/Opcode.js on lines 516..526
      src/Opcode.js on lines 582..591
      src/Opcode.js on lines 592..602
      src/Opcode.js on lines 603..613
      src/Opcode.js on lines 705..715

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if(this.isImm(label)){
                                  state.code.push(`${indent}${v} = ${label.getValue()};`);
                                  Logger.debug(`${indent}${v} = ${label.getValue()};`);
                              }
                              else if(label.hasCode()){
      Severity: Major
      Found in src/SmaliVM.js and 1 other location - About 1 hr to fix
      src/SmaliVM.js on lines 3850..3857

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              else if(label.hasCode()){
                                  state.code.push(`${indent}${v} = ${label.getCode()};`);
                                  Logger.debug(`${indent}${v} = ${label.getCode()};`);
                              }
                              else{
      Severity: Major
      Found in src/SmaliVM.js and 1 other location - About 1 hr to fix
      src/SmaliVM.js on lines 3846..3857

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getIntentFilter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getIntentFilter(type,cmp,uid){
              let result = null;
      
              switch(type)
              {
      Severity: Minor
      Found in src/AndroidAppAnalyzer.js - About 1 hr to fix

        Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor(pContext, pMethod = null, pLocalSize = null, pParamSize = null){
                
                this.context = pContext;
        
                this.logs = new VM_Log();
        Severity: Minor
        Found in src/SmaliVM.js - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language