Sign upLogin

FrenchYeti/dexcalibur

View on GitHub
Star

Showing 948 of 948 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(success){
            this.status = new StatusMessage(30, this.status.append("[Device Manager] Profiling successfull.\n[Device Manager] Start Frida server install"));
        }else{
            this.status = StatusMessage.newError( this.status.append("[Device Manager] Fail to profile the device"));
        }
Severity: Minor
Found in src/DeviceManager.js and 1 other location - About 50 mins to fix
src/DeviceManager.js on lines 584..588

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(success){
            this.status = new StatusMessage(70, this.status.append("[Device Manager] Frida server installed.\n[Device Manager] Start platform install ..."));
        }else{
            this.status = StatusMessage.newError( this.status.append("[Device Manager] Fail"));
        }
Severity: Minor
Found in src/DeviceManager.js and 1 other location - About 50 mins to fix
src/DeviceManager.js on lines 559..563

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                        if(this.isImm(regV)){
                            regX = this.getRegisterName(oper.left[0]);
                            this.setSymbol(regX, regV.addInt8(this.getImmediateValue(oper.right)));
                        }else{
                           v = `${this.getRegisterName(oper.left[0])} = ${this.getRegisterName(oper.left[1])}+${this.getImmediateValue(oper.right)};`;
Severity: Minor
Found in src/Decompiler.js and 1 other location - About 50 mins to fix
src/Decompiler.js on lines 1028..1033

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                        if(this.isImm(regV)){
                            regX = this.getRegisterName(oper.left[0]);
                            this.setSymbol(regX, regV.add(this.getImmediateValue(oper.right), oper.opcode.byte));
                        }else{
                            v = `${this.getRegisterName(oper.left[0])} = ${this.getRegisterName(oper.left[1])}+${this.getImmediateValue(oper.right)};`;
Severity: Minor
Found in src/Decompiler.js and 1 other location - About 50 mins to fix
src/Decompiler.js on lines 764..769

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                    if(this.simplify<1){
                        v = `${this.getRegisterName(oper.left[0])} = ${this.getRegisterName(oper.left[1])}+${this.getRegisterName(oper.right)};`;
                        
                    }else{
                        regX = this.getRegisterName(oper.right);
Severity: Major
Found in src/Decompiler.js and 2 other locations - About 50 mins to fix
src/Decompiler.js on lines 757..770
src/Decompiler.js on lines 1021..1034

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                else if(instr[k].opcode.type == CONST.INSTR_TYPE.RET){
                    Logger.debug(`Block ${i} RETURN`)
                    jump = true;
                }
Severity: Major
Found in src/Simplifier.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if( (this.config.maxdepth==-1) || (this.config.maxdepth - this.stack.depth()) > 0){
                        
                        
                        this.invoke( dec.inv.meth, dec.inv.obj, dec.inv.args);
    Severity: Major
    Found in src/SmaliVM.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if(this.stack.callstack.length==1) this.pcmaker.turnOn();
      Severity: Major
      Found in src/SmaliVM.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        else if(dec.ret != null){
                    break;
                }
                else{
                    i++;
        Severity: Major
        Found in src/SmaliVM.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if(regV.getValue() instanceof VM_ClassInstance){

                            v = `// ${regX}=(ClassInstance)${regV.getValue().parent.name} is not null, so "if(${regX} != 0)" was TRUE. Continue ...`;
                            state.jump = {type:CONST.INSTR_TYPE.IF, label:oper.right.name};
          Severity: Major
          Found in src/SmaliVM.js - About 45 mins to fix

            Function print has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                print(){
        let m=`
Call stack :
`;
            Severity: Minor
            Found in src/SmaliVM.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if(pArguments["p"+i].val != null)
                            this.stack.last().addArgument(i, getDataTypeOf(margs[i]), 
                                this.heap.newInstance(margs[i]._name).setConcrete(pArguments["p"+i].val));
                        else if(pArguments["p"+i].notset==true)
                            this.stack.last().addArgument(i, getDataTypeOf(margs[i]), this.heap.newInstance(margs[i]._name));
            Severity: Major
            Found in src/SmaliVM.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if(regV.hasCode()){
                                this.stack.setLocalSymbol(
                                    regV, 
                                    DTYPE.IMM_NUMERIC,
                                    null,
              Severity: Major
              Found in src/SmaliVM.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if(blocks[i+1].hasPredecessor(blocks[i])==false){
                            blocks[i+1].addPredecessor(blocks[i]);
                        }
                Severity: Major
                Found in src/Simplifier.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if(next == null){
                        
                        Logger.error("[VM] Basic block 'goto_"+instr[k].right.name+"' targeted by goto is not found.");
                    }
                  Severity: Major
                  Found in src/SmaliVM.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    if(bbs.isTryEndBlock()){
                    if(bbs.hasCatchStatement()){
                        d = bbs.getCatchStatements();
                        for(let i=0; i<d.length; i++){
                            if(d[i].getException() != null)
                    Severity: Major
                    Found in src/SmaliVM.js - About 45 mins to fix

                      Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          constructor(config=null){
        // the manifest data are stored here

        this.attr = {};
                      Severity: Minor
                      Found in src/AndroidAppComponents.js - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                          if(blocks[i].hasSuccessor(next)==false){
                        blocks[i].addSuccessor(next);
                    }
                      Severity: Major
                      Found in src/SmaliVM.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if(f==0) 
                        this.pcmaker.push(`try{`);
                    else
                        this.pcmaker.push(`${CR}try{`);
                        Severity: Major
                        Found in src/SmaliVM.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if(next.hasPredecessor(blocks[i])==false){
                        next.addPredecessor(blocks[i]);
                    }
                          Severity: Major
                          Found in src/Simplifier.js - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language