Freshly/spicerack

View on GitHub

Showing 7 of 58 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Filter
    extend ActiveSupport::Concern

    included do
      delegate :default_filter, :default_filter?, to: :class
Severity: Minor
Found in facet/lib/facet/concerns/filter.rb and 1 other location - About 35 mins to fix
facet/lib/facet/concerns/sort.rb on lines 5..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Sort
    extend ActiveSupport::Concern

    included do
      delegate :default_sort, :default_sort?, to: :class
Severity: Minor
Found in facet/lib/facet/concerns/sort.rb and 1 other location - About 35 mins to fix
facet/lib/facet/concerns/filter.rb on lines 5..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  match { |subject| expect(subject.junction_key).to eq key }
  description { "have junction key `#{key}'" }
  failure_message do |subject|
    "expected #{subject} to have junction key `#{key}' but had `#{subject.junction_key}'"
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_prefix.rb on lines 18..21
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_suffix.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype.rb on lines 18..20
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype_name.rb on lines 16..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  match { |subject| expect(subject.conjunction_prefix).to eq prefix }
  description { "have conjunction prefix `#{prefix}'" }
  failure_message do |subject|
    "expected #{subject} to have conjunction prefix `#{prefix}' but had `#{subject.conjunction_prefix}'"
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_suffix.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_junction_key.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype.rb on lines 18..20
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype_name.rb on lines 16..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  match { |subject| expect(subject.prototype_name).to eq prototype_name }
  description { "have prototype name `#{prototype_name}'" }
  failure_message do |subject|
    "expected #{subject} to have prototype name `#{prototype_name}' but had `#{subject.prototype_name}'"
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_prefix.rb on lines 18..21
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_suffix.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_junction_key.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype.rb on lines 18..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  match { |subject| expect(subject.prototype).to eq prototype }
  description { "have prototype name `#{prototype}'" }
  failure_message { |subject| "expected #{subject} to have prototype `#{prototype}' but had `#{subject.prototype}'" }
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_prefix.rb on lines 18..21
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_suffix.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_junction_key.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype_name.rb on lines 16..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  match { |subject| expect(subject.conjunction_suffix).to eq suffix }
  description { "have conjunction suffix `#{suffix}'" }
  failure_message do |subject|
    "expected #{subject} to have conjunction suffix `#{suffix}' but had `#{subject.conjunction_prefix}'"
conjunction/lib/conjunction/rspec/custom_matchers/have_conjunction_prefix.rb on lines 18..21
conjunction/lib/conjunction/rspec/custom_matchers/have_junction_key.rb on lines 16..19
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype.rb on lines 18..20
conjunction/lib/conjunction/rspec/custom_matchers/have_prototype_name.rb on lines 16..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language