Sign upLogin

Fs02/grimoire

View on GitHub
Star

Showing 25 of 42 total issues

Query has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

type Query struct {
    repo            *Repo
    Collection      string
    Fields          []string
    AggregateField  string
Severity: Minor
Found in query.go - About 4 hrs to fix

    Method Form.convert has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
    Open

    func (form Form) convert(str string, typ reflect.Type) (interface{}, bool) {
    result := interface{}(nil)
    valid := false

    switch typ.Kind() {
    Severity: Minor
    Found in params/form.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Builder has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type Builder struct {
    config      *Config
    returnField string
    count       int
}
    Severity: Minor
    Found in adapter/sql/bulder.go - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func CheckConstraint(t *testing.T, repo grimoire.Repo) {
    extra := Extra{}
    repo.From(extras).MustSave(&extra)

    t.Run("CheckConstraint", func(t *testing.T) {
      Severity: Major
      Found in adapter/specs/constraint.go and 1 other location - About 2 hrs to fix
      adapter/specs/constraint.go on lines 29..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 194.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ForeignKeyConstraint(t *testing.T, repo grimoire.Repo) {
    extra := Extra{}
    repo.From(extras).MustSave(&extra)

    t.Run("ForeignKeyConstraint", func(t *testing.T) {
      Severity: Major
      Found in adapter/specs/constraint.go and 1 other location - About 2 hrs to fix
      adapter/specs/constraint.go on lines 45..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 194.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, test := range tests {
        ch := changeset.Cast(test.record, test.params, []string{"name", "age", "note", "address", "user_id"})
        statement, _ := builder.Update(test.query.Collection, ch.Changes(), test.query.Condition)

        t.Run("Update|"+statement, func(t *testing.T) {
      Severity: Major
      Found in adapter/specs/update.go and 1 other location - About 2 hrs to fix
      adapter/specs/update.go on lines 65..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, test := range tests {
        ch := changeset.Cast(test.schema, test.params, []string{"name", "age", "note", "address", "user_id"})
        statement, _ := builder.Update(test.query.Collection, ch.Changes(), test.query.Condition)

        t.Run("UpdateWhere|"+statement, func(t *testing.T) {
      Severity: Major
      Found in adapter/specs/update.go and 1 other location - About 2 hrs to fix
      adapter/specs/update.go on lines 34..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method Form.convert has 73 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (form Form) convert(str string, typ reflect.Type) (interface{}, bool) {
    result := interface{}(nil)
    valid := false

    switch typ.Kind() {
      Severity: Minor
      Found in params/form.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (adapter *Adapter) Commit() error {
    var err error

    if adapter.Tx == nil {
        err = errors.NewUnexpected("unable to commit outside transaction")
        Severity: Major
        Found in adapter/sql/sql.go and 1 other location - About 1 hr to fix
        adapter/sql/sql.go on lines 136..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (adapter *Adapter) Rollback() error {
    var err error

    if adapter.Tx == nil {
        err = errors.NewUnexpected("unable to rollback outside transaction")
        Severity: Major
        Found in adapter/sql/sql.go and 1 other location - About 1 hr to fix
        adapter/sql/sql.go on lines 121..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method JSON.convert has 54 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (json *JSON) convert(value gjson.Result, typ reflect.Type) (interface{}, bool) {
    if value.Type == gjson.Null {
        return nil, true
    }
        Severity: Minor
        Found in params/json.go - About 1 hr to fix

          Function ParseForm has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
          Open

          func ParseForm(raw url.Values) Form {
    result := make(Form, len(raw))

    for k, v := range raw {
        if len(v) == 0 {
          Severity: Minor
          Found in params/form.go - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Not has 9 return statements (exceeds 4 allowed).
          Open

          func Not(inner ...Condition) Condition {
    if len(inner) == 1 {
        c := inner[0]
        switch c.Type {
        case ConditionEq:
          Severity: Major
          Found in c/condition.go - About 55 mins to fix

            Method JSON.convert has 7 return statements (exceeds 4 allowed).
            Open

            func (json *JSON) convert(value gjson.Result, typ reflect.Type) (interface{}, bool) {
    if value.Type == gjson.Null {
        return nil, true
    }
            Severity: Major
            Found in params/json.go - About 45 mins to fix

              Method Map.GetWithType has 6 return statements (exceeds 4 allowed).
              Open

              func (m Map) GetWithType(name string, typ reflect.Type) (interface{}, bool) {
    value := m[name]

    if value == nil {
        return nil, true
              Severity: Major
              Found in params/map.go - About 40 mins to fix

                Function ValidateRange has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func ValidateRange(ch *Changeset, field string, min int, max int, opts ...Option) {
                Severity: Minor
                Found in changeset/validate_range.go - About 35 mins to fix

                  Method Query.Save has 5 return statements (exceeds 4 allowed).
                  Open

                  func (query Query) Save(record interface{}) error {
    rv := reflect.ValueOf(record)
    rt := rv.Type()
    if rt.Kind() == reflect.Ptr && rt.Elem().Kind() == reflect.Slice {
        // Put multiple records
                  Severity: Major
                  Found in query.go - About 35 mins to fix

                    Your code does not pass gofmt in 1 place. Go fmt your code!
                    Open

                    // Package mysql wraps mysql driver as an adapter for grimoire.
                    Severity: Minor
                    Found in adapter/mysql/mysql.go by gofmt

                    Your code does not pass gofmt in 1 place. Go fmt your code!
                    Open

                    // Package postgres wraps postgres (pq) driver as an adapter for grimoire.
                    Severity: Minor
                    Found in adapter/postgres/postgres.go by gofmt

                    2: cannot find package "github.com/Fs02/go-paranoid" in any of:
                    Open

                        "github.com/Fs02/go-paranoid"
                    Severity: Minor
                    Found in adapter/mysql/mysql.go by govet
                    Severity
                    Category
                    Status
                    Source
                    Language