Furious-PHP/psr7

View on GitHub

Showing 16 of 16 total issues

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $method, $uri, string $version = '1.1', array $headers = [],
        array $queryParams = [], $body = null,
        array $serverParams = [], array $cookieParams = [],
        array $files = [], array $attributes = []
Severity: Major
Found in src/ServerRequest.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($xml, int $statusCode = 200, array $headers = [], $body = null, string $version = '1.1', string $reason = null)
    Severity: Minor
    Found in src/Response/XmlResponse.php - About 45 mins to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(string $text, int $statusCode = 200, array $headers = [], $body = null, string $version = '1.1', string $reason = null)
      Severity: Minor
      Found in src/Response/TextResponse.php - About 45 mins to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($uri, int $statusCode = 302, array $headers = [], $body = null, string $version = '1.1', string $reason = null)
        Severity: Minor
        Found in src/Response/RedirectResponse.php - About 45 mins to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct(array $data, int $statusCode = 200, array $headers = [], $body = null, string $version = '1.1', string $reason = null)
          Severity: Minor
          Found in src/Response/JsonResponse.php - About 45 mins to fix

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct(string $html, int $statusCode = 200, array $headers = [], $body = null, string $version = '1.1', string $reason = null)
            Severity: Minor
            Found in src/Response/HtmlResponse.php - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              <?php
              
              declare(strict_types=1);
              
              namespace Furious\Psr7\Response;
              Severity: Minor
              Found in src/Response/HtmlResponse.php and 1 other location - About 45 mins to fix
              src/Response/TextResponse.php on lines 1..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              <?php
              
              declare(strict_types=1);
              
              namespace Furious\Psr7\Response;
              Severity: Minor
              Found in src/Response/TextResponse.php and 1 other location - About 45 mins to fix
              src/Response/HtmlResponse.php on lines 1..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function  __construct(string $method, $uri, array $headers = [], $body = null, string $version = '1.1')
              Severity: Minor
              Found in src/Request.php - About 35 mins to fix

                Method createUploadedFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        StreamInterface $stream, ?int $size = null, int $error = UPLOAD_ERR_OK,
                        string $clientFilename = null, string $clientMediaType = null
                Severity: Minor
                Found in src/Factory/UploadedFileFactory.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $streamOrFile, ?int $size, int $error,
                          string $clientFileName = null, string $clientMediaType = null
                  Severity: Minor
                  Found in src/UploadedFile.php - About 35 mins to fix

                    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            int $statusCode = 200, array $headers = [], $body = null,
                            string $version = '1.1', string $reason = null
                    Severity: Minor
                    Found in src/Response.php - About 35 mins to fix

                      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function __construct(int $offset, int $whence, $message = '', $code = 0, Throwable $previous = null)
                      Severity: Minor
                      Found in src/Exception/UnableToSeekException.php - About 35 mins to fix

                        Function buildPathByAuthority has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function buildPathByAuthority(string $path, string $authority): string
                            {
                                $newPath = $path;
                        
                                if ('/' !== $path[0]) {
                        Severity: Minor
                        Found in src/Builder/UriBuilder.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function setHeaders has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function setHeaders(array $headers): void
                            {
                                foreach ($headers as $header => $value) {
                                    if (is_integer($header)) {
                                        $header = (string) $header;
                        Severity: Minor
                        Found in src/Message.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function get(): array
                            {
                                $headers = [];
                                foreach ($this->serverParameters as $key => $value) {
                                    if (!is_string($key) or $value === '') {
                        Severity: Minor
                        Found in src/Header/HeadersCollection.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language