Futsch1/medTimer

View on GitHub
app/src/main/java/com/futsch1/medtimer/statistics/CalendarFragment.kt

Summary

Maintainability
A
0 mins
Test Coverage

Method setupDayBinder has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    private fun setupDayBinder() {
        class DayViewContainer(view: View) : ViewContainer(view) {
            val textView: TextView = view.findViewById(R.id.calendarDayText)
            lateinit var day: CalendarDay

Severity: Major
Found in app/src/main/java/com/futsch1/medtimer/statistics/CalendarFragment.kt - About 2 hrs to fix

    Method setupMonthBinder has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        private fun setupMonthBinder() {
            class MonthViewContainer(view: View) : ViewContainer(view) {
                val textView: TextView = view.findViewById(R.id.monthHeaderText)
                val prevButton: MaterialButton = view.findViewById(R.id.prevMonth)
                val nextButton: MaterialButton = view.findViewById(R.id.nextMonth)

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                      prevButton.setOnClickListener {
                          calendarView?.scrollToMonth(calendarView?.findFirstVisibleMonth()?.yearMonth!!.previousMonth)
                      }
      app/src/main/java/com/futsch1/medtimer/statistics/CalendarFragment.kt on lines 107..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                      nextButton.setOnClickListener {
                          calendarView?.scrollToMonth(calendarView?.findFirstVisibleMonth()?.yearMonth!!.nextMonth)
                      }
      app/src/main/java/com/futsch1/medtimer/statistics/CalendarFragment.kt on lines 104..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status