Showing 95 of 95 total issues
File Importer.js
has 441 lines of code (exceeds 250 allowed). Consider refactoring. Open
// @flow
import path from 'path';
import requireRelative from 'require-relative';
File configurationSchema.js
has 422 lines of code (exceeds 250 allowed). Consider refactoring. Open
import Ajv from 'ajv';
import ajvInstanceof from 'ajv-keywords/dist/keywords/instanceof';
import globals from 'globals';
import findPackageDependencies from './findPackageDependencies';
import { DEFAULT_PARSER_PLUGINS } from './parse.js';
Function convertToImportStatement
has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring. Open
function convertToImportStatement(
node: Object,
source: string,
): ?ImportStatement {
if (node.type === 'ImportDeclaration') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ExportsStorage.js
has 368 lines of code (exceeds 250 allowed). Consider refactoring. Open
import sqlite3 from 'sqlite3';
import lastUpdate from './lastUpdate';
const MAX_CHUNK_SIZE = 100;
Function normalizeNode
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
function normalizeNode(node, context) {
const { key, parent } = context;
if (!parent) {
return undefined;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File findExports.js
has 354 lines of code (exceeds 250 allowed). Consider refactoring. Open
import fs from 'fs';
import path from 'path';
import requireRelative from 'require-relative';
Function convertToImportStatement
has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
function convertToImportStatement(
node: Object,
source: string,
): ?ImportStatement {
if (node.type === 'ImportDeclaration') {
Similar blocks of code found in 2 locations. Consider refactoring. Open
program
.command('rewrite <pathToFile>')
.option(...sharedOptions.overwrite)
.action((pathToFile: string, options: Object) => {
const executor = (importer: Importer): Promise<Object> =>
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
program
.command('fix <pathToFile>')
.option(...sharedOptions.overwrite)
.action((pathToFile: string, options: Object) => {
const executor = (importer: Importer): Promise<Object> =>
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function processQueue
has 70 lines of code (exceeds 25 allowed). Consider refactoring. Open
processQueue(done) {
const file = this.queue.pop();
if (!file) {
this.processingQueue = false;
winston.debug('Queue empty');
Function normalizeNode
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
function normalizeNode(node, context) {
const { key, parent } = context;
if (!parent) {
return undefined;
}
Function daemon
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function daemon(parentPid, pathToLogFile) {
process.stdout.write(
`ImportJS (v${version()}) DAEMON active. Logs will go to: ${pathToLogFile}\n`,
);
if (parentPid) {
File ImportStatement.js
has 269 lines of code (exceeds 250 allowed). Consider refactoring. Open
// @flow
function isLineTooLong(line: string, maxLineLength: number): boolean {
return !!maxLineLength && line.length > maxLineLength;
}
Function findCommonJSExports
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
function findCommonJSExports(
node,
{ definedNames, absolutePathToFile, aliasesForExports },
) {
if (node.type !== 'ExpressionStatement') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function subscribe
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
subscribe({
client,
fbWatch,
relativePath,
}: {
Function extractExportsFromMeteorPackage
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
function extractExportsFromMeteorPackage(
projectRootDir: string,
pkg: string,
pkgVersion: string,
): ?Array<string> {
Function findJsModulesFromModuleFinder
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
function findJsModulesFromModuleFinder(
config: Configuration,
normalizedName: string,
variableName: string,
finder: ModuleFinder,
Function init
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
init(dbFilename) {
return new Promise((resolve, reject) => {
this.db = new sqlite3.Database(dbFilename);
this.db.all('PRAGMA table_info(exports)', (pragmaErr, result) => {
if (pragmaErr) {
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (removedItems.size === 1 && firstRemoved) {
messageParts.push(`Removed \`${firstRemoved}\`.`);
} else if (removedItems.size) {
messageParts.push(`Removed ${removedItems.size} imports.`);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (addedItems.size === 1 && firstAdded) {
messageParts.push(`Imported ${firstAdded}`);
} else if (addedItems.size) {
messageParts.push(`Added ${addedItems.size} imports`);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76