Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/base/dimensionmanager.js

Summary

Maintainability
C
1 day
Test Coverage

Function getDimensionModelsForSpace has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  getDimensionModelsForSpace(oldSpace, newSpaceDimensions) {

    this.updateDimensionModels();

    // match new space to entities
Severity: Minor
Found in src/base/dimensionmanager.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDimensionModelsForSpace has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  getDimensionModelsForSpace(oldSpace, newSpaceDimensions) {

    this.updateDimensionModels();

    // match new space to entities
Severity: Major
Found in src/base/dimensionmanager.js - About 2 hrs to fix

    Function newSpace has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const newSpace = newSpaceDimensions.map((dim, index) => {

      /**
       * HEURISTIC 1: use old space and map new space on those entities (works only for same-dimensional)
       */
    Severity: Minor
    Found in src/base/dimensionmanager.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

            return "entities_" + dim;
      Severity: Major
      Found in src/base/dimensionmanager.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status