Genshin/phantom_svg

View on GitHub

Showing 20 of 20 total issues

Class Base has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Base
      attr_accessor :frames, :width, :height, :loops, :skip_first

      def initialize(path = nil, options = {})
        reset
Severity: Minor
Found in lib/phantom/svg.rb - About 2 hrs to fix

    Class SVGWriter has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class SVGWriter < AbstractImageWriter
            # Write svg file from object to path.
            # Return write size.
            def write(path, object)
              return 0 if path.nil? || path.empty? || object.nil?
    Severity: Minor
    Found in lib/phantom/parser/svg_writer.rb - About 2 hrs to fix

      Method combine has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def combine(path)
              src = Base.new(path, {unique_ids: true})
      
              if @width != src.width || @height != src.height
                fail "Can't combine source images of different sizes."
      Severity: Minor
      Found in lib/phantom/svg.rb - About 1 hr to fix

        Method set_width has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def set_width(width)
                if width.nil?
                  if @width.nil? || @width == 0
                    frames.each do |frame|
                      @width = frame.width.to_i if frame.width.to_i > @width
        Severity: Minor
        Found in lib/phantom/svg.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method set_height has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def set_height(height)
                if height.nil?
                  if @height.nil? || @height == 0
                    frames.each do |frame|
                      @height = frame.height.to_i if frame.height.to_i > @height
        Severity: Minor
        Found in lib/phantom/svg.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method write_proc has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def write_proc(object)
                  if object.is_a?(Base)
                    if object.frames.size == 1    then  write_svg(object.frames[0])
                    elsif object.frames.size > 1  then  write_animation_svg(object)
                    else                                return false
        Severity: Minor
        Found in lib/phantom/parser/svg_writer.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method combine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def combine(path)
                src = Base.new(path, {unique_ids: true})
        
                if @width != src.width || @height != src.height
                  fail "Can't combine source images of different sizes."
        Severity: Minor
        Found in lib/phantom/svg.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def load_from_jpeg(path, options)
                reader = Parser::JPEGReader.new(path, options)
                
                if reader.has_animation?
                  @loops = reader.loops
        Severity: Major
        Found in lib/phantom/svg.rb and 3 other locations - About 35 mins to fix
        lib/phantom/svg.rb on lines 186..199
        lib/phantom/svg.rb on lines 202..215
        lib/phantom/svg.rb on lines 234..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def load_from_gif(path, option)
                reader = Parser::GIFReader.new(path, option)
                
                if reader.has_animation?
                  @loops = reader.loops
        Severity: Major
        Found in lib/phantom/svg.rb and 3 other locations - About 35 mins to fix
        lib/phantom/svg.rb on lines 186..199
        lib/phantom/svg.rb on lines 202..215
        lib/phantom/svg.rb on lines 218..231

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def set_width(node, dest, options = {})
                  if node.attributes['width'].nil?
                    dest.instance_variable_set(:@width,
                                               choice_value("#{dest.viewbox.width}px", options[:width]))
                  else
        Severity: Minor
        Found in lib/phantom/parser/svg_reader.rb and 1 other location - About 35 mins to fix
        lib/phantom/parser/svg_reader.rb on lines 99..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def set_height(node, dest, options = {})
                  if node.attributes['height'].nil?
                    dest.instance_variable_set(:@height,
                                               choice_value("#{dest.viewbox.height}px", options[:height]))
                  else
        Severity: Minor
        Found in lib/phantom/parser/svg_reader.rb and 1 other location - About 35 mins to fix
        lib/phantom/parser/svg_reader.rb on lines 89..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def load_from_svg(path, options)
                reader = Parser::SVGReader.new(path, options)
                
                if reader.has_animation?
                  @loops = reader.loops
        Severity: Major
        Found in lib/phantom/svg.rb and 3 other locations - About 35 mins to fix
        lib/phantom/svg.rb on lines 202..215
        lib/phantom/svg.rb on lines 218..231
        lib/phantom/svg.rb on lines 234..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def load_from_png(path, options)
                reader = Parser::PNGReader.new(path, options)
                
                if reader.has_animation?
                  @loops = reader.loops
        Severity: Major
        Found in lib/phantom/svg.rb and 3 other locations - About 35 mins to fix
        lib/phantom/svg.rb on lines 186..199
        lib/phantom/svg.rb on lines 218..231
        lib/phantom/svg.rb on lines 234..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method _replace_id_refs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def _replace_id_refs(id, new_id)
                  @root.elements.each("//*") do |element|
                    element.attributes['style'].gsub!(/url\(\##{id}\)/, "url(\##{new_id})") if element.attributes['style'] != nil
                    element.attributes['fill'].gsub!(/\##{id}$/, "\##{new_id}") if element.attributes['fill'] != nil
                    element.attributes['xlink:href'].gsub!(/\##{id}$/, "\##{new_id}") if element.attributes['xlink:href'] != nil
        Severity: Minor
        Found in lib/phantom/parser/svg_reader.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_frames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def create_frames
                  i = 0
                  @frame_infos.each do |frame_info|
                    create_file_list(frame_info[:name]).each do |file|
                      reader = Parser::SVGReader.new(file, create_options(i, frame_info[:delay]))
        Severity: Minor
        Found in lib/phantom/parser/abstract_animation_reader.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_file_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def create_file_list(path)
                  result = Dir.glob(path).sort_by { |k| k[/\d+/].to_i }
                  if result.empty?
                    result <<
                      if    File.exist?(path)           then  path
        Severity: Minor
        Found in lib/phantom/parser/abstract_animation_reader.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def create_surfaces(path, width, height)
                  bin = File.binread(path)
                  base64 = [bin].pack('m')
        
                  image = REXML::Element.new('image')
        Severity: Minor
        Found in lib/phantom/parser/jpeg_reader.rb and 1 other location - About 25 mins to fix
        lib/phantom/parser/png_reader.rb on lines 86..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def create_surfaces(path, width, height)
                  bin = File.binread(path)
                  base64 = [bin].pack('m')
        
                  image = REXML::Element.new('image')
        Severity: Minor
        Found in lib/phantom/parser/png_reader.rb and 1 other location - About 25 mins to fix
        lib/phantom/parser/jpeg_reader.rb on lines 42..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def set_height(height)
                if height.nil?
                  if @height.nil? || @height == 0
                    frames.each do |frame|
                      @height = frame.height.to_i if frame.height.to_i > @height
        Severity: Minor
        Found in lib/phantom/svg.rb and 1 other location - About 20 mins to fix
        lib/phantom/svg.rb on lines 63..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def set_width(width)
                if width.nil?
                  if @width.nil? || @width == 0
                    frames.each do |frame|
                      @width = frame.width.to_i if frame.width.to_i > @width
        Severity: Minor
        Found in lib/phantom/svg.rb and 1 other location - About 20 mins to fix
        lib/phantom/svg.rb on lines 75..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language