GladysProject/Gladys

View on GitHub
front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx

Summary

Maintainability
F
5 days
Test Coverage

Function render has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render({ deviceIndex, device, housesWithRooms, editable, ...props }, { loading, errorMessage }) {
    const validModel = device.features && device.features.length > 0;
    const online = device.params.find(param => param.name === DEVICE_ONLINE).value === '1';
    const firmware = device.params.find(param => param.name === DEVICE_FIRMWARE).value;

Severity: Major
Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx - About 5 hrs to fix

    Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      render({ deviceIndex, device, housesWithRooms, editable, ...props }, { loading, errorMessage }) {
        const validModel = device.features && device.features.length > 0;
        const online = device.params.find(param => param.name === DEVICE_ONLINE).value === '1';
        const firmware = device.params.find(param => param.name === DEVICE_FIRMWARE).value;
    
    
    Severity: Minor
    Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <div class="form-group">
                      {validModel && props.alreadyCreatedButton && (
                        <button class="btn btn-primary mr-2" disabled="true">
                          <Text id="integration.eWeLink.alreadyCreatedButton" />
                        </button>
    Severity: Major
    Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx and 1 other location - About 2 days to fix
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 277..315

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 355.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <div class="form-group">
                      <label class="form-label" for={`name_${deviceIndex}`}>
                        <Text id="integration.eWeLink.nameLabel" />
                      </label>
                      <Localizer>
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 174..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 166.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      saveDevice = async () => {
        this.setState({
          loading: true,
          errorMessage: null
        });
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 25..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 147.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                      <select
                        id={`room_${deviceIndex}`}
                        onChange={this.updateRoom}
                        class="form-control"
                        disabled={!editable || !validModel}
    front/src/routes/integration/all/bluetooth/device-page/BluetoothDevice.jsx on lines 95..109
    front/src/routes/integration/all/bluetooth/setup-page/setup-peripheral/ConfigurePeripheralForm.jsx on lines 188..202
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 195..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      deleteDevice = async () => {
        this.setState({
          loading: true,
          errorMessage: null
        });
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 46..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    {validModel && (
                      <div class="form-group">
                        <label class="form-label">
                          <Text id="integration.eWeLink.device.featuresLabel" />
                        </label>
    front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx on lines 268..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      updateRoom = e => {
        this.props.updateDeviceField(this.props.listName, this.props.deviceIndex, 'room_id', e.target.value);
      };
    Severity: Major
    Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx and 6 other locations - About 55 mins to fix
    front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx on lines 10..12
    front/src/routes/scene/edit-scene/actions/CalendarIsEventRunning.jsx on lines 56..58
    front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 11..13
    front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 81..83
    front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 84..86
    front/src/routes/scene/edit-scene/actions/SendMessageParams.jsx on lines 35..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      updateName = e => {
        this.props.updateDeviceField(this.props.listName, this.props.deviceIndex, 'name', e.target.value);
      };
    Severity: Major
    Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx and 6 other locations - About 55 mins to fix
    front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx on lines 14..16
    front/src/routes/scene/edit-scene/actions/CalendarIsEventRunning.jsx on lines 56..58
    front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 11..13
    front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 81..83
    front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 84..86
    front/src/routes/scene/edit-scene/actions/SendMessageParams.jsx on lines 35..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      <input
                        id={`model_${deviceIndex}`}
                        type="text"
                        value={device.model}
                        class="form-control"
    Severity: Minor
    Found in front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx and 1 other location - About 40 mins to fix
    front/src/routes/integration/all/zigbee2mqtt/discover-page/DiscoveredBox.jsx on lines 122..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status