GladysProject/Gladys

View on GitHub

Showing 1,294 of 1,801 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  'get /api/v1/user/tony': {
    id: 'd84ced32-d937-4cf6-a32e-105ffb584226',
    firstname: 'Tony',
    lastname: 'Stark',
    selector: 'tony',
Severity: Minor
Found in front/src/config/demo.js and 1 other location - About 35 mins to fix
front/src/config/demo.js on lines 744..753

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  [EVENTS.USER_PRESENCE.LEFT_HOME]: (event, trigger) => event.house === trigger.house && event.user === trigger.user,
Severity: Major
Found in server/lib/scene/scene.triggers.js and 3 other locations - About 35 mins to fix
server/lib/scene/scene.triggers.js on lines 22..22
server/lib/scene/scene.triggers.js on lines 26..26
server/lib/scene/scene.triggers.js on lines 27..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                          <li>
                            <i class="fe fe-check text-success mr-2" aria-hidden="true" />{' '}
                            <Text id="integration.googleHome.controlDevices" />
                          </li>
Severity: Minor
Found in front/src/routes/integration/all/google-home-gateway/index.js and 2 other locations - About 35 mins to fix
front/src/routes/integration/all/google-home-gateway/index.js on lines 91..94
front/src/routes/integration/all/google-home-gateway/index.js on lines 99..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    cy.intercept(
      {
        method: 'GET',
        url: `${serverUrl}/api/v1/service/bluetooth/status`
      },
front/cypress/integration/routes/integration/bluetooth/discover/BluetoothDiscover.js on lines 36..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    cy.intercept(
      {
        method: 'POST',
        url: `${serverUrl}/api/v1/service/bluetooth/scan`
      },
front/cypress/integration/routes/integration/bluetooth/discover/BluetoothDiscover.js on lines 8..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  [EVENTS.AREA.USER_ENTERED]: (event, trigger) => event.user === trigger.user && event.area === trigger.area,
Severity: Major
Found in server/lib/scene/scene.triggers.js and 3 other locations - About 35 mins to fix
server/lib/scene/scene.triggers.js on lines 22..22
server/lib/scene/scene.triggers.js on lines 23..23
server/lib/scene/scene.triggers.js on lines 27..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const daysOfTheWeekOptions = weekDays.map(weekDay => ({
      value: weekDay,
      label: <Text id={`editScene.triggersCard.scheduledTrigger.daysOfTheWeek.${weekDay}`} />
    }));
Severity: Minor
Found in front/src/routes/scene/edit-scene/actions/CheckTime.jsx and 1 other location - About 35 mins to fix
front/src/routes/scene/edit-scene/triggers/ChooseTriggerTypeCard.jsx on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (!(characteristic.properties || []).includes('read')) {
    throw new BadParameters(`Bluetooth: not readable characteristic ${characteristic.uuid}`);
  }
server/services/bluetooth/lib/utils/characteristic/bluetooth.write.js on lines 18..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  'get /api/v1/user/pepper': {
    id: 'd84ced32-d937-4cf6-a32e-105ffb584226',
    firstname: 'Pepper',
    lastname: 'Pots',
    selector: 'pepper',
Severity: Minor
Found in front/src/config/demo.js and 1 other location - About 35 mins to fix
front/src/config/demo.js on lines 734..743

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                          <li>
                            <i class="fe fe-check text-success mr-2" aria-hidden="true" />{' '}
                            <Text id="integration.googleHome.getNewDeviceValues" />
                          </li>
Severity: Minor
Found in front/src/routes/integration/all/google-home-gateway/index.js and 2 other locations - About 35 mins to fix
front/src/routes/integration/all/google-home-gateway/index.js on lines 91..94
front/src/routes/integration/all/google-home-gateway/index.js on lines 95..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  [ACTIONS.USER.SET_SEEN_AT_HOME]: async (self, action) => {
    await self.house.userSeen(action.house, action.user);
  },
Severity: Minor
Found in server/lib/scene/scene.actions.js and 1 other location - About 35 mins to fix
server/lib/scene/scene.actions.js on lines 238..240

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  [ACTIONS.USER.SET_OUT_OF_HOME]: async (self, action) => {
    await self.house.userLeft(action.house, action.user);
  },
Severity: Minor
Found in server/lib/scene/scene.actions.js and 1 other location - About 35 mins to fix
server/lib/scene/scene.actions.js on lines 235..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

      {props.errorLink && (
        <div class="alert alert-danger" role="alert">
          <Text id="gatewayResetPassword.errorLinkLabel" />
        </div>
      )}
Severity: Major
Found in front/src/routes/gateway-reset-password/ResetPasswordForm.js and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 10..14
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 20..24
front/src/components/user/profile.jsx on lines 25..29
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-forgot-password/ForgotPassword.js on lines 27..31
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14
front/src/routes/signup-gateway/SignupForm.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

      {props.unknownError && (
        <div class="alert alert-danger" role="alert">
          <Text id="profile.unknownError" />
        </div>
      )}
Severity: Major
Found in front/src/components/user/profile.jsx and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 20..24
front/src/components/user/profile.jsx on lines 25..29
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-forgot-password/ForgotPassword.js on lines 27..31
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 15..19
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14
front/src/routes/signup-gateway/SignupForm.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  async function get(req, res) {
    const areas = await gladys.area.get();
    res.json(areas);
  }
Severity: Major
Found in server/api/controllers/area.controller.js and 6 other locations - About 30 mins to fix
server/api/controllers/gateway.controller.js on lines 10..13
server/api/controllers/gateway.controller.js on lines 53..56
server/api/controllers/gateway.controller.js on lines 75..78
server/api/controllers/system.controller.js on lines 10..13
server/api/controllers/system.controller.js on lines 20..23
server/api/controllers/system.controller.js on lines 30..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

      {props.emailAlreadyExistError && (
        <div class="alert alert-danger" role="alert">
          <Text id="profile.emailAlreadyExistError" />
        </div>
      )}
Severity: Major
Found in front/src/components/user/profile.jsx and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 10..14
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 25..29
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-forgot-password/ForgotPassword.js on lines 27..31
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 15..19
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14
front/src/routes/signup-gateway/SignupForm.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

                {props.success && (
                  <div class="alert alert-success" role="alert">
                    <Text id="gatewayForgotPassword.success" />
                  </div>
                )}
Severity: Major
Found in front/src/routes/gateway-forgot-password/ForgotPassword.js and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 10..14
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 20..24
front/src/components/user/profile.jsx on lines 25..29
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 15..19
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14
front/src/routes/signup-gateway/SignupForm.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  async function getBackups(req, res) {
    const backups = await gladys.gateway.getBackups();
    res.json(backups);
  }
Severity: Major
Found in server/api/controllers/gateway.controller.js and 6 other locations - About 30 mins to fix
server/api/controllers/area.controller.js on lines 89..92
server/api/controllers/gateway.controller.js on lines 10..13
server/api/controllers/gateway.controller.js on lines 53..56
server/api/controllers/system.controller.js on lines 10..13
server/api/controllers/system.controller.js on lines 20..23
server/api/controllers/system.controller.js on lines 30..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

      {props.invitationError && (
        <div class="alert alert-danger" role="alert">
          <Text id="gatewaySignup.invalidInvitationError" />
        </div>
      )}
Severity: Major
Found in front/src/routes/signup-gateway/SignupForm.js and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 10..14
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 20..24
front/src/components/user/profile.jsx on lines 25..29
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-forgot-password/ForgotPassword.js on lines 27..31
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 15..19
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

      {props.selectorAlreadyExist && (
        <div class="alert alert-danger" role="alert">
          <Text id="profile.selectorAlreadyExistError" />
        </div>
      )}
Severity: Major
Found in front/src/components/user/profile.jsx and 12 other locations - About 30 mins to fix
front/src/components/user/profile.jsx on lines 10..14
front/src/components/user/profile.jsx on lines 15..19
front/src/components/user/profile.jsx on lines 20..24
front/src/components/user/profile.jsx on lines 30..34
front/src/routes/gateway-configure-two-factor/ConfigureTwoFactorForm.js on lines 45..49
front/src/routes/gateway-forgot-password/ForgotPassword.js on lines 27..31
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 15..19
front/src/routes/gateway-reset-password/ResetPasswordForm.js on lines 20..24
front/src/routes/settings/settings-backup/GatewayBackupList.jsx on lines 23..27
front/src/routes/settings/settings-gateway-users/UserList.js on lines 13..17
front/src/routes/signup-gateway/SignupForm.js on lines 10..14
front/src/routes/signup-gateway/SignupForm.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language