GoVanguard/legion

View on GitHub
app/settings.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function backupAndSave has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def backupAndSave(self, newSettings, saveBackup=True):
        # Backup and save
        if saveBackup:
            log.info('Backing up old settings and saving new settings...')
            os.rename('./legion.conf', './backup/' + getTimestamp() + '-legion.conf')
Severity: Major
Found in app/settings.py - About 2 hrs to fix

Function __init__ has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def __init__(self, appSettings=None):

        # general
        self.general_default_terminal = "gnome-terminal"
        self.general_tool_output_black_background = "False"
Severity: Minor
Found in app/settings.py - About 1 hr to fix

Function backupAndSave has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def backupAndSave(self, newSettings, saveBackup=True):
        # Backup and save
        if saveBackup:
            log.info('Backing up old settings and saving new settings...')
            os.rename('./legion.conf', './backup/' + getTimestamp() + '-legion.conf')
Severity: Minor
Found in app/settings.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status