Sign upLogin

GrafiteInc/CMS

View on GitHub
Star

Showing 103 of 103 total issues

Function collectSiteMapItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function collectSiteMapItems()
    {
        $itemCollection = [];
        $modules = config('site-mapped-modules', [
            'blog' => 'Grafite\Cms\Repositories\BlogRepository',
Severity: Minor
Found in src/Services/CmsService.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFileContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFileContent($fileName, $contentType, $ext)
    {
        if (Storage::disk(config('cms.storage-location', 'local'))->exists($fileName)) {
            $fileContent = Storage::disk(config('cms.storage-location', 'local'))->get($fileName);
        } elseif (!is_null(config('filesystems.cloud.key'))) {
Severity: Minor
Found in src/Services/AssetService.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function breadcrumbs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function breadcrumbs($locations)
    {
        $trail = '';

        foreach ($locations as $location) {
Severity: Minor
Found in src/Services/CmsService.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function preview has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function preview($entity, $id)
    {
        $modelString = 'Grafite\Cms\Models\\'.ucfirst($entity);

        if (!class_exists($modelString)) {
Severity: Minor
Found in src/Controllers/GrafiteCmsFeatureController.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ($(this).is(':checked')) {
            $('#External_url').parent().show();
            $('#Page_id').parent().hide();
        } else {
            $('#External_url').parent().hide();
Severity: Minor
Found in src/Assets/src/js/modules.js and 1 other location - About 35 mins to fix
src/Assets/src/js/modules.js on lines 17..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ($('#External').is(':checked')) {
    $('#External_url').parent().show();
    $('#Page_id').parent().hide();
} else {
    $('#External_url').parent().hide();
Severity: Minor
Found in src/Assets/src/js/modules.js and 1 other location - About 35 mins to fix
src/Assets/src/js/modules.js on lines 27..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return "<?php echo Cms::editBtnSecondary($expression); ?>";
Severity: Major
Found in src/GrafiteCmsProvider.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return new BlogService();
    Severity: Major
    Found in src/Providers/CmsServiceProvider.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new ModuleService();
      Severity: Major
      Found in src/Providers/CmsServiceProvider.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return "<?php echo Markdown::convertToHtml($expression); ?>";
        Severity: Major
        Found in src/GrafiteCmsProvider.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return "<?php echo Cms::moduleLinks($expression); ?>";
          Severity: Major
          Found in src/GrafiteCmsProvider.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return "<?php echo Cms::promotion($expression); ?>";
            Severity: Major
            Found in src/GrafiteCmsProvider.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return "<?php echo Cms::image($expression); ?>";
              Severity: Major
              Found in src/GrafiteCmsProvider.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return "<?php echo Cms::images($expression); ?>";
                Severity: Major
                Found in src/GrafiteCmsProvider.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return "<?php echo Cms::imageLink($expression); ?>";
                  Severity: Major
                  Found in src/GrafiteCmsProvider.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return "<?php echo Cms::widget($expression); ?>";
                    Severity: Major
                    Found in src/GrafiteCmsProvider.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return "<?php echo Cms::editBtn($expression); ?>";
                      Severity: Major
                      Found in src/GrafiteCmsProvider.php - About 30 mins to fix

                        Function getTemplatesAsOptionsArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function getTemplatesAsOptionsArray($module)
    {
        $availableTemplates = ['show'];
        $templates = glob(base_path('resources/themes/'.config('cms.frontend-theme').'/'.$module.'/*'));
                        Severity: Minor
                        Found in src/Services/BaseService.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function allTags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function allTags()
    {
        $tags = [];
        $images = $this->model->orderBy('created_at', 'desc')->where('is_published', 1)->get();
                        Severity: Minor
                        Found in src/Repositories/ImageRepository.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function calendar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function calendar($date)
    {
        $events = $this->eventRepository->all();
        $dateArray = explode('-', $date);
        $daysInMonth = Carbon::create($dateArray[0], $dateArray[1], $dateArray[2])->daysInMonth;
                        Severity: Minor
                        Found in src/Services/EventService.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language