Sign upLogin

HHRy/prawn-graph

View on GitHub
Star
lib/prawn/graph/chart_components/line_chart_renderer.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method has too many lines. [38/30]
Open

        def render_line_chart
          prawn.bounding_box [@graph_area.point[0] + 5, @graph_area.point[1] - 20], width: @plot_area_width, height: @plot_area_height do
            j = 2
            prawn.save_graphics_state do  
              max_marked = false
Severity: Minor
Found in lib/prawn/graph/chart_components/line_chart_renderer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method render_line_chart has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        def render_line_chart
          prawn.bounding_box [@graph_area.point[0] + 5, @graph_area.point[1] - 20], width: @plot_area_width, height: @plot_area_height do
            j = 2
            prawn.save_graphics_state do  
              max_marked = false
Severity: Minor
Found in lib/prawn/graph/chart_components/line_chart_renderer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_line_chart has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def render_line_chart
          prawn.bounding_box [@graph_area.point[0] + 5, @graph_area.point[1] - 20], width: @plot_area_width, height: @plot_area_height do
            j = 2
            prawn.save_graphics_state do  
              max_marked = false
Severity: Minor
Found in lib/prawn/graph/chart_components/line_chart_renderer.rb - About 1 hr to fix

    Method apply_marker_to_graph has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def apply_marker_to_graph(value_marked, value, x, y, color)
    Severity: Minor
    Found in lib/prawn/graph/chart_components/line_chart_renderer.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status