Sign upLogin

HR/Crypter

View on GitHub
Star

Showing 17 of 32 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ipcRenderer.on('export', function () {
  dialog
    .showOpenDialog({
      title: 'Choose a dir to export to',
      defaultPath: paths.documents,
Severity: Major
Found in app/static/js/settings.js and 1 other location - About 5 hrs to fix
app/static/js/settings.js on lines 60..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ipcRenderer.on('import', function () {
  dialog
    .showOpenDialog({
      title: 'Choose the crypter credentials file',
      defaultPath: paths.documents,
Severity: Major
Found in app/static/js/settings.js and 1 other location - About 5 hrs to fix
app/static/js/settings.js on lines 27..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File crypto.js has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'
/**
 * crypto.js
 * Provides the crypto functionality required
 ******************************/
Severity: Minor
Found in app/core/crypto.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      dataOrig
                    .on('error', err => reject(err))
                    .pipe(decipher)
                    .on('error', err => reject(err))
                    .pipe(dataDest)
    Severity: Major
    Found in app/core/crypto.js and 1 other location - About 1 hr to fix
    app/core/crypto.js on lines 89..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              origin
            .on('error', err => reject(err))
            .pipe(cipher)
            .on('error', err => reject(err))
            .pipe(dataDest)
    Severity: Major
    Found in app/core/crypto.js and 1 other location - About 1 hr to fix
    app/core/crypto.js on lines 206..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ipcRenderer.on('decryptedFile', function (event, file) {
  logger.verbose(`IPCRENDER decryptedFile emitted`)
  let fileHTML = crypted_template(file)
  cryptedContainer.html(fileHTML)
  enableUI()
    Severity: Major
    Found in app/static/js/crypter.js and 1 other location - About 1 hr to fix
    app/static/js/crypter.js on lines 40..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ipcRenderer.on('cryptedFile', function (event, file) {
  logger.verbose(`IPCRENDER cryptedFile emitted`)
  let fileHTML = crypted_template(file)
  cryptedContainer.html(fileHTML)
  enableUI()
    Severity: Major
    Found in app/static/js/crypter.js and 1 other location - About 1 hr to fix
    app/static/js/crypter.js on lines 48..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function checkUpdate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      checkUpdate: function () {
    return new Promise((resolve, reject) => {
      https.get(REPO.RELEASES_API_URL, {
          headers: { 'User-Agent': USER_AGENT }
        }, (res) => {
    Severity: Minor
    Found in app/utils/update.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ipcRenderer.on('decryptingFile', function (event, file) {
  logger.verbose(`IPCRENDER decryptingFile emitted`)
  fileInputText.text(`Decrypting ${basename(file)}...`)
  disableUI()
})
      Severity: Major
      Found in app/static/js/crypter.js and 1 other location - About 1 hr to fix
      app/static/js/crypter.js on lines 62..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ipcRenderer.on('encryptingFile', function (event, file) {
  logger.verbose(`IPCRENDER encryptingFile emitted`)
  fileInputText.text(`Encrypting ${basename(file)}...`)
  disableUI()
})
      Severity: Major
      Found in app/static/js/crypter.js and 1 other location - About 1 hr to fix
      app/static/js/crypter.js on lines 68..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function deriveKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.deriveKey = (pass, psalt) => {
  return new Promise((resolve, reject) => {
    // reject with error if pass not provided
    if (!pass) reject(new Error('Pass to derive key from not provided'))
      Severity: Minor
      Found in app/core/crypto.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function MasterPassKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const MasterPassKey = (function () {
  // Private mpk variable that stores the MasterPassKey
  const mpk = new WeakMap()

  // Class constructor
      Severity: Minor
      Found in app/core/MasterPassKey.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

      /* TODO: ADD MARGIN RELATIVELY/CONTEXTUALLY TO CORE ELEMENTS I.E. for a button, use panel-container > button*/
      Severity: Minor
      Found in app/static/styles/setup.less by fixme

      TODO found
      Open

      furnished TODO so, subject to the following conditions:
      Severity: Minor
      Found in license by fixme

      TODO found
      Open

      furnished TODO so, subject to the following conditions:
      Severity: Minor
      Found in build/license.txt by fixme

      TODO found
      Open

      /* TODO DISABLE ANIMATION ON FIRST PANE */
      Severity: Minor
      Found in app/static/styles/setup.less by fixme

      TODO found
      Open

      // TODO: Make independent from global obj! use param instead
      Severity: Minor
      Found in app/core/MasterPass.js by fixme
      Severity
      Category
      Status
      Source
      Language