HabitRPG/habitrpg

View on GitHub
website/common/script/content/gear/sets/armoire.js

Summary

Maintainability
F
5 days
Test Coverage

File armoire.js has 1855 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import defaults from 'lodash/defaults';
import find from 'lodash/find';
import forEach from 'lodash/forEach';
import moment from 'moment';
import upperFirst from 'lodash/upperFirst';
Severity: Major
Found in website/common/script/content/gear/sets/armoire.js - About 5 days to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      violetFloppyHat: {
        notes: t('headArmoireVioletFloppyHatNotes', { per: 5, int: 5, con: 5 }),
        per: 5,
        int: 5,
        con: 5,
    Severity: Major
    Found in website/common/script/content/gear/sets/armoire.js and 4 other locations - About 50 mins to fix
    website/common/script/content/gear/sets/armoire.js on lines 23..29
    website/common/script/content/gear/sets/armoire.js on lines 566..572
    website/common/script/content/gear/sets/armoire.js on lines 586..592
    website/common/script/content/gear/sets/armoire.js on lines 597..603

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      redHairbow: {
        notes: t('headArmoireRedHairbowNotes', { str: 5, int: 5, con: 5 }),
        str: 5,
        int: 5,
        con: 5,
    Severity: Major
    Found in website/common/script/content/gear/sets/armoire.js and 4 other locations - About 50 mins to fix
    website/common/script/content/gear/sets/armoire.js on lines 23..29
    website/common/script/content/gear/sets/armoire.js on lines 573..579
    website/common/script/content/gear/sets/armoire.js on lines 586..592
    website/common/script/content/gear/sets/armoire.js on lines 597..603

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      rancherHat: {
        notes: t('headArmoireRancherHatNotes', { str: 5, per: 5, int: 5 }),
        str: 5,
        per: 5,
        int: 5,
    Severity: Major
    Found in website/common/script/content/gear/sets/armoire.js and 4 other locations - About 50 mins to fix
    website/common/script/content/gear/sets/armoire.js on lines 23..29
    website/common/script/content/gear/sets/armoire.js on lines 566..572
    website/common/script/content/gear/sets/armoire.js on lines 573..579
    website/common/script/content/gear/sets/armoire.js on lines 597..603

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      blueHairbow: {
        notes: t('headArmoireBlueHairbowNotes', { per: 5, int: 5, con: 5 }),
        per: 5,
        int: 5,
        con: 5,
    Severity: Major
    Found in website/common/script/content/gear/sets/armoire.js and 4 other locations - About 50 mins to fix
    website/common/script/content/gear/sets/armoire.js on lines 23..29
    website/common/script/content/gear/sets/armoire.js on lines 566..572
    website/common/script/content/gear/sets/armoire.js on lines 573..579
    website/common/script/content/gear/sets/armoire.js on lines 586..592

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      rancherRobes: {
        notes: t('armorArmoireRancherRobesNotes', { str: 5, per: 5, int: 5 }),
        str: 5,
        per: 5,
        int: 5,
    Severity: Major
    Found in website/common/script/content/gear/sets/armoire.js and 4 other locations - About 50 mins to fix
    website/common/script/content/gear/sets/armoire.js on lines 566..572
    website/common/script/content/gear/sets/armoire.js on lines 573..579
    website/common/script/content/gear/sets/armoire.js on lines 586..592
    website/common/script/content/gear/sets/armoire.js on lines 597..603

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status