Sign upLogin

HabitRPG/habitrpg

View on GitHub
Star
website/common/script/libs/shops.js

Summary

Maintainability
F
3 days
Test Coverage

File shops.js has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import values from 'lodash/values';
import map from 'lodash/map';
import keys from 'lodash/keys';
import get from 'lodash/get';
import each from 'lodash/each';
Severity: Minor
Found in website/common/script/libs/shops.js - About 5 hrs to fix

    Function getTimeTravelersCategories has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    shops.getTimeTravelersCategories = function getTimeTravelersCategories (user, language) {
  const categories = [];
  const stable = { pets: 'Pet-', mounts: 'Mount_Icon_' };

  const officialPinnedItems = getOfficialPinnedItems(user);
    Severity: Major
    Found in website/common/script/libs/shops.js - About 3 hrs to fix

      Function getTimeTravelersCategories has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      shops.getTimeTravelersCategories = function getTimeTravelersCategories (user, language) {
  const categories = [];
  const stable = { pets: 'Pet-', mounts: 'Mount_Icon_' };

  const officialPinnedItems = getOfficialPinnedItems(user);
      Severity: Minor
      Found in website/common/script/libs/shops.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSeasonalShopCategories has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      shops.getSeasonalShopCategories = function getSeasonalShopCategories (user, language) {
  const officialPinnedItems = getOfficialPinnedItems(user);

  const AVAILABLE_SPELLS = [
    ...seasonalShopConfig.availableSpells,
      Severity: Minor
      Found in website/common/script/libs/shops.js - About 1 hr to fix

        Function getMarketGear has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        shops.getMarketGearCategories = function getMarketGear (user, language) {
  const categories = [];
  const officialPinnedItems = getOfficialPinnedItems(user);

  for (const classType of content.classes) {
        Severity: Minor
        Found in website/common/script/libs/shops.js - About 1 hr to fix

          Function checkMarketGearLocked has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          shops.checkMarketGearLocked = function checkMarketGearLocked (user, items) {
  const result = filter(items, ['pinType', 'marketGear']);
  const officialPinnedItems = getOfficialPinnedItems(user);
  const availableGear = map(updateStore(user), item => getItemInfo(user, 'marketGear', item, officialPinnedItems).path);
  for (const gear of result) {
          Severity: Minor
          Found in website/common/script/libs/shops.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getMarket has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          shops.getMarketCategories = function getMarket (user, language) {
  const officialPinnedItems = getOfficialPinnedItems(user);

  const categories = [];
  const eggsCategory = {
          Severity: Minor
          Found in website/common/script/libs/shops.js - About 1 hr to fix

            Function checkMarketGearLocked has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            shops.checkMarketGearLocked = function checkMarketGearLocked (user, items) {
  const result = filter(items, ['pinType', 'marketGear']);
  const officialPinnedItems = getOfficialPinnedItems(user);
  const availableGear = map(updateStore(user), item => getItemInfo(user, 'marketGear', item, officialPinnedItems).path);
  for (const gear of result) {
            Severity: Minor
            Found in website/common/script/libs/shops.js - About 1 hr to fix

              Function getSeasonalGearBySet has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                user,
  set,
  officialPinnedItems,
  language,
  ignoreAlreadyOwned = false,
              Severity: Minor
              Found in website/common/script/libs/shops.js - About 35 mins to fix

                Function getMarketGear has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                shops.getMarketGearCategories = function getMarketGear (user, language) {
  const categories = [];
  const officialPinnedItems = getOfficialPinnedItems(user);

  for (const classType of content.classes) {
                Severity: Minor
                Found in website/common/script/libs/shops.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getSeasonalGearBySet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                shops.getSeasonalGearBySet = function getSeasonalGearBySet (
  user,
  set,
  officialPinnedItems,
  language,
                Severity: Minor
                Found in website/common/script/libs/shops.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (keys(quests).length > 0) {
    const category = {
      identifier: 'quests',
      text: i18n.t('quests', language),
    };
                Severity: Major
                Found in website/common/script/libs/shops.js and 1 other location - About 2 hrs to fix
                website/common/script/libs/shops.js on lines 481..493

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 85.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (keys(spells).length > 0) {
    const category = {
      identifier: 'spells',
      text: i18n.t('seasonalItems', language),
    };
                Severity: Major
                Found in website/common/script/libs/shops.js and 1 other location - About 2 hrs to fix
                website/common/script/libs/shops.js on lines 497..506

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 85.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status