Sign upLogin

HabitRPG/habitrpg

View on GitHub
Star
website/server/libs/tasks/index.js

Summary

Maintainability
F
5 days
Test Coverage

File index.js has 476 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import moment from 'moment';
import cloneDeep from 'lodash/cloneDeep';
import compact from 'lodash/compact';
import forEach from 'lodash/forEach';
import keys from 'lodash/keys';
Severity: Minor
Found in website/server/libs/tasks/index.js - About 7 hrs to fix

    Function getTasks has 139 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function getTasks (req, res, options = {}) {
  const {
    user,
    challenge,
    group,
    Severity: Major
    Found in website/server/libs/tasks/index.js - About 5 hrs to fix

      Function getTasks has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getTasks (req, res, options = {}) {
  const {
    user,
    challenge,
    group,
      Severity: Minor
      Found in website/server/libs/tasks/index.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function scoreTask has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

      async function scoreTask (user, task, direction, req, res) {
  if (task.type === 'daily' || task.type === 'todo') {
    if (task.group.id && task.group.assignedUsersDetail
      && task.group.assignedUsersDetail[user._id]
    ) {
      Severity: Minor
      Found in website/server/libs/tasks/index.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function scoreTask has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function scoreTask (user, task, direction, req, res) {
  if (task.type === 'daily' || task.type === 'todo') {
    if (task.group.id && task.group.assignedUsersDetail
      && task.group.assignedUsersDetail[user._id]
    ) {
      Severity: Major
      Found in website/server/libs/tasks/index.js - About 4 hrs to fix

        Function createTasks has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        async function createTasks (req, res, options = {}) {
  const {
    user,
    challenge,
    group,
        Severity: Major
        Found in website/server/libs/tasks/index.js - About 2 hrs to fix

          Function scoreTasks has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function scoreTasks (user, taskScorings, req, res) {
  // Validate the parameters

  // taskScorings must be array with at least one value
  if (!taskScorings || !Array.isArray(taskScorings) || taskScorings.length < 1) {
          Severity: Major
          Found in website/server/libs/tasks/index.js - About 2 hrs to fix

            Function verifyTaskModification has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function verifyTaskModification (task, user, group, challenge, res) {
  if (!task) {
    throw new NotFound(res.t('messageTaskNotFound'));
  } else if (task.group.id && !task.userId) {
    if (!group) throw new NotFound(res.t('groupNotFound'));
            Severity: Minor
            Found in website/server/libs/tasks/index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handleTeamTask has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            async function handleTeamTask (task, delta, direction) {
  if (task.group && task.group.taskId) {
    // Wrapping everything in a try/catch block because if an error occurs
    // using `await` it MUST NOT bubble up because the request has already been handled
    try {
            Severity: Minor
            Found in website/server/libs/tasks/index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function scoreTasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            export async function scoreTasks (user, taskScorings, req, res) {
  // Validate the parameters

  // taskScorings must be array with at least one value
  if (!taskScorings || !Array.isArray(taskScorings) || taskScorings.length < 1) {
            Severity: Minor
            Found in website/server/libs/tasks/index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Consider simplifying this complex logical expression.
            Open

              if (
    group && task.group.id && !task.userId // Task is on team board
    && ['todo', 'daily'].includes(task.type) // Task is a To Do or Daily
    && direction === 'down' // Task is being "unchecked"
  ) {
            Severity: Major
            Found in website/server/libs/tasks/index.js - About 40 mins to fix

              Function verifyTaskModification has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function verifyTaskModification (task, user, group, challenge, res) {
              Severity: Minor
              Found in website/server/libs/tasks/index.js - About 35 mins to fix

                Function scoreTask has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                async function scoreTask (user, task, direction, req, res) {
                Severity: Minor
                Found in website/server/libs/tasks/index.js - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        upgradedGroups = await Group.find(
        {
          _id: { $in: groupsToMirror },
          'purchased.plan.customerId': { $exists: true },
          $or: [
                  Severity: Major
                  Found in website/server/libs/tasks/index.js and 1 other location - About 2 hrs to fix
                  website/server/libs/user/index.js on lines 177..187

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 90.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status