Sign upLogin

HabitRPG/habitrpg

View on GitHub
Star
website/server/models/task.js

Summary

Maintainability
D
1 day
Test Coverage

Function scoreChallengeTask has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

TaskSchema.methods.scoreChallengeTask = async function scoreChallengeTask (delta, direction) {
  const chalTask = this;

  if (chalTask.type !== 'reward') chalTask.value += delta;
Severity: Minor
Found in website/server/models/task.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File task.js has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import mongoose from 'mongoose';
import validator from 'validator';
import moment from 'moment';
import _ from 'lodash';
import shared from '../../common';
Severity: Minor
Found in website/server/models/task.js - About 4 hrs to fix

    Function scoreChallengeTask has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    TaskSchema.methods.scoreChallengeTask = async function scoreChallengeTask (delta, direction) {
  const chalTask = this;

  if (chalTask.type !== 'reward') chalTask.value += delta;
    Severity: Minor
    Found in website/server/models/task.js - About 1 hr to fix

      Function findMultipleByIdOrAlias has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      TaskSchema.statics.findMultipleByIdOrAlias = async function findMultipleByIdOrAlias (
  identifiers,
  userId,
  additionalQueries = {},
) {
      Severity: Minor
      Found in website/server/models/task.js - About 1 hr to fix

        Function findMultipleByIdOrAlias has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        TaskSchema.statics.findMultipleByIdOrAlias = async function findMultipleByIdOrAlias (
  identifiers,
  userId,
  additionalQueries = {},
) {
        Severity: Minor
        Found in website/server/models/task.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sanitizeTransform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          sanitizeTransform (taskObj) {
    if (taskObj.type && taskObj.type !== 'reward') { // value should be settable directly only for rewards
      delete taskObj.value;
    }
        Severity: Minor
        Found in website/server/models/task.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          $and: [ // exclude challenge and group tasks
    {
      $or: [
        { 'challenge.id': { $exists: false } },
        { 'challenge.broken': { $exists: true } },
        Severity: Major
        Found in website/server/models/task.js and 1 other location - About 2 hrs to fix
        website/server/controllers/api-v3/tasks.js on lines 1363..1376

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status