Sign upLogin

Hack23/cia

View on GitHub
Star
service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method createUserAccount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private UserAccount createUserAccount(final RegisterUserRequest serviceRequest) {

        final ApplicationConfiguration registeredUsersGetAdminConfig = applicationConfigurationService
                .checkValueOrLoadDefault("Registered User All get Role Admin", "Registered User All get Role Admin",
                        ConfigurationGroup.AUTHORIZATION, RegisterUserService.class.getSimpleName(),
Severity: Minor
Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java - About 1 hr to fix

    Method processService has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    @Secured({ "ROLE_ANONYMOUS" })
    public RegisterUserResponse processService(final RegisterUserRequest serviceRequest) {
        final RegisterUserResponse inputValidation = inputValidation(serviceRequest);
        if (inputValidation != null) {
    Severity: Minor
    Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java - About 1 hr to fix

      Method processService has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    @Secured({ "ROLE_ANONYMOUS" })
    public RegisterUserResponse processService(final RegisterUserRequest serviceRequest) {
        final RegisterUserResponse inputValidation = inputValidation(serviceRequest);
        if (inputValidation != null) {
      Severity: Minor
      Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    protected CreateApplicationEventRequest createApplicationEventForService(
            final RegisterUserRequest serviceRequest) {
        final CreateApplicationEventRequest eventRequest = createBaseApplicationEventRequest();
        eventRequest.setEventGroup(ApplicationEventGroup.USER);
      Severity: Minor
      Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java and 1 other location - About 55 mins to fix
      service.impl/src/main/java/com/hack23/cia/service/impl/action/application/LoginService.java on lines 161..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private final PasswordValidator passwordValidator = new PasswordValidator(new LengthRule(8, 64),
            new CharacterRule(EnglishCharacterData.UpperCase, 1), new CharacterRule(EnglishCharacterData.LowerCase, 1),
            new CharacterRule(EnglishCharacterData.Digit, 1), new CharacterRule(EnglishCharacterData.Special, 1),
            new WhitespaceRule());
      Severity: Minor
      Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/application/RegisterUserService.java and 1 other location - About 35 mins to fix
      service.impl/src/main/java/com/hack23/cia/service/impl/action/user/ChangePasswordService.java on lines 73..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status