service.impl/src/main/java/com/hack23/cia/service/impl/rules/AbstractComplianceCheckImpl.java
Method addViolation has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public final void addViolation(final Status status,final String ruleName,final String ruleGroup,final String ruleDescription,final String positive) {Change the visibility of this constructor to "protected". Open
Open
public AbstractComplianceCheckImpl(final ResourceType resourceType) {- Read upRead up
- Exclude checks
Abstract classes should not have public constructors. Constructors of abstract classes can only be called in constructors of their subclasses. So
there is no point in making them public. The protected modifier should be enough.
Noncompliant Code Example
public abstract class AbstractClass1 {
public AbstractClass1 () { // Noncompliant, has public modifier
// do something here
}
}
Compliant Solution
public abstract class AbstractClass2 {
protected AbstractClass2 () {
// do something here
}
}