Sign upLogin

Hanmac/rwx

View on GitHub
Star

Showing 15 of 15 total issues

Method on_init has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    def on_init
    
    
#    
#        #f = WX::Font.new(10,:script)
Severity: Minor
Found in old_tests/test.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method on_init has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def on_init
    
    
#    
#        #f = WX::Font.new(10,:script)
Severity: Major
Found in old_tests/test.rb - About 6 hrs to fix

File test.rb has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "../ext/rwx"
require "../../tiled_tmx/map"
require "nokogiri"

module TiledTmx
Severity: Minor
Found in old_tests/test.rb - About 2 hrs to fix

Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(parent)
        super(parent,:title => "Map Properies",:style => DEFAULT_STYLE | RESIZE_BORDER)
        
        self.sizer = WX::BoxSizer.new {|box|
            box.orientation = true
Severity: Minor
Found in old_tests/test.rb - About 1 hr to fix

Method create_menu_select has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create_menu_select(select)
        select.append_normal(:single_choice,"&Single choice\tCtrl-C") {
            dialog = WX::SingleChoiceDialog.new(@frame,
                :message => "This is a small sample\nA single-choice convenience dialog",
                :title => "Please select a value",
Severity: Minor
Found in samples/dialog/dialog_sample.rb - About 1 hr to fix

Method on_init has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def on_init

    
        @frame = WX::Frame.new(nil)
        #@frame.title = "hallo"
Severity: Minor
Found in old_tests/button.rb - About 1 hr to fix

Method draw has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def draw(id,x,y,z,opacity,rot,x_scale,y_scale,&block)
Severity: Major
Found in old_tests/test.rb - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            sbs.add(WX::BoxSizer.new {|siz|
                siz.add(WX::RadioButton.new(self,:label => "An",:group => true,:disabled=>true))
                siz.add(WX::RadioButton.new(self,:label => "Aus",:disabled=>true))
                siz.add(WX::RadioButton.new(self,:label => "Eltern-Map",:disabled=>true))
            },:expand => true)
Severity: Minor
Found in old_tests/test.rb and 1 other location - About 55 mins to fix
old_tests/test.rb on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            sbs.add(WX::BoxSizer.new {|siz|
                siz.add(WX::RadioButton.new(self,:label => "An",:group => true,:disabled=>true))
                siz.add(WX::RadioButton.new(self,:label => "Aus",:disabled=>true))
                siz.add(WX::RadioButton.new(self,:label => "Eltern-Map",:disabled=>true))
            },:expand => true)
Severity: Minor
Found in old_tests/test.rb and 1 other location - About 55 mins to fix
old_tests/test.rb on lines 61..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method draw has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def draw(grid,att,dc,rect,row,col,selected)
Severity: Major
Found in old_tests/test.rb - About 50 mins to fix

Method add_radiobox has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def add_radiobox(sizer, label, choices, id = nil, &block)
Severity: Minor
Found in samples/widgets/pages/common.rb - About 35 mins to fix

Method best_size has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def best_size(grid,att,dc,row,col)
Severity: Minor
Found in old_tests/test.rb - About 35 mins to fix

Method add_button has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def add_button(sizer, label, id = nil, **opt, &block)
Severity: Minor
Found in samples/widgets/pages/common.rb - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                slider.bind(:scroll_thumbtrack) {|e|
                                    sel = wnd[:layerlist].selection.instance_variable_get(:@layer)
                                    sel.opacity = e.position / 256.0 if sel
                                    @frame[:paint].refresh if @frame[:paint]
Severity: Minor
Found in old_tests/test.rb and 1 other location - About 25 mins to fix
old_tests/test.rb on lines 467..470

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                slider.bind(:scroll_changed) {|e|
                                    sel = wnd[:layerlist].selection.instance_variable_get(:@layer)
                                    sel.opacity = e.position / 256.0 if sel
                                    @frame[:paint].refresh if @frame[:paint]
Severity: Minor
Found in old_tests/test.rb and 1 other location - About 25 mins to fix
old_tests/test.rb on lines 472..475

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language