Showing 224 of 224 total issues
Method "__init__" has 19 parameters, which is greater than the 7 authorized. Open
Open
self,
sentence: Sentence,
char_start: int,
char_end: int,
expander_key: str,
- Read upRead up
- Exclude checks
A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.
Noncompliant Code Example
With a maximum number of 4 parameters:
def do_something(param1, param2, param3, param4, param5): ...
Compliant Solution
def do_something(param1, param2, param3, param4): ...
Refactor this function to reduce its Cognitive Complexity from 72 to the 15 allowed. Open
Open
def _parse_file(self, fp: str, file_name: str) -> Iterator[Document]:
- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Function "log_model" has 15 parameters, which is greater than the 7 authorized. Open
Open
fonduer_model: FonduerModel,
artifact_path: str,
preprocessor: DocPreprocessor,
parser: Parser,
mention_extractor: MentionExtractor,
- Read upRead up
- Exclude checks
A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.
Noncompliant Code Example
With a maximum number of 4 parameters:
def do_something(param1, param2, param3, param4, param5): ...
Compliant Solution
def do_something(param1, param2, param3, param4): ...
Function "save_model" has 16 parameters, which is greater than the 7 authorized. Open
Open
fonduer_model: FonduerModel,
path: str,
preprocessor: DocPreprocessor,
parser: Parser,
mention_extractor: MentionExtractor,
- Read upRead up
- Exclude checks
A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.
Noncompliant Code Example
With a maximum number of 4 parameters:
def do_something(param1, param2, param3, param4, param5): ...
Compliant Solution
def do_something(param1, param2, param3, param4): ...