Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/themes/UniversalTheme.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method ApplyPlot has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function ApplyPlot($plot)
    {
        switch (get_class($plot)) {
            case 'GroupBarPlot':
                    foreach ($plot->plots as $_plot) {
Severity: Minor
Found in src/themes/UniversalTheme.php - About 1 hr to fix

    Function ApplyPlot has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function ApplyPlot($plot)
    {
        switch (get_class($plot)) {
            case 'GroupBarPlot':
                    foreach ($plot->plots as $_plot) {
    Severity: Minor
    Found in src/themes/UniversalTheme.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method SetupGraph has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function SetupGraph($graph)
    {
        // graph
        /*
        $img = $graph->img;
    Severity: Minor
    Found in src/themes/UniversalTheme.php - About 1 hr to fix

      The method ApplyPlot() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public function ApplyPlot($plot)
    {
        switch (get_class($plot)) {
            case 'GroupBarPlot':
                    foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Method name "UniversalTheme::SetupGraph" is not in camel caps format
      Open

          public function SetupGraph($graph)
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Method name "UniversalTheme::ApplyPlot" is not in camel caps format
      Open

          public function ApplyPlot($plot)
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Method name "UniversalTheme::SetupPieGraph" is not in camel caps format
      Open

          public function SetupPieGraph($graph)
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Method name "UniversalTheme::GetColorList" is not in camel caps format
      Open

          public function GetColorList()
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Method name "UniversalTheme::PreStrokeApply" is not in camel caps format
      Open

          public function PreStrokeApply($graph)
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $this->ApplyPlot($_plot);
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $plot->SetColor($color);
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $color = $this->GetNextColor();
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $plot->Clear();
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $this->ApplyPlot($_plot);
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $plot->SetShadow('red', 3, 4, false);
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $plot->SetFillColor($color);
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          }
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          }
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          if (!$plot->fill) {
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          }
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/UniversalTheme.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status