Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
tests/GeneralTest.php

Summary

Maintainability
C
1 day
Test Coverage

Avoid using static access to class '\Codeception\Util\Debug' in method 'setUpBeforeClass'.
Open

        Debug::debug(__CLASS__ . ' has ' . \count(self::$files) . ' files');
Severity: Minor
Found in tests/GeneralTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

/**
 * JPGraph - Community Edition
 */
Severity: Major
Found in tests/GeneralTest.php and 3 other locations - About 1 day to fix
tests/ContourTest.php on lines 1..55
tests/RotateTest.php on lines 1..55
tests/ScatterTest.php on lines 1..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class GeneralTest extends \Codeception\Test\Unit
Severity: Minor
Found in tests/GeneralTest.php by phpcodesniffer

Method name "_after" should not be prefixed with an underscore to indicate visibility
Open

    protected function _after()
Severity: Minor
Found in tests/GeneralTest.php by phpcodesniffer

Method name "_before" should not be prefixed with an underscore to indicate visibility
Open

    protected function _before()
Severity: Minor
Found in tests/GeneralTest.php by phpcodesniffer

Whitespace found at end of line
Open

 *
Severity: Minor
Found in tests/GeneralTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status