IL2HorusTeam/il2fb-commons

View on GitHub

Showing 4 of 4 total issues

Function parse_requirements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def parse_requirements(file_path: Path) -> List[str]:
  requirements = list()

  if not file_path.exists():
    return requirements
Severity: Minor
Found in setup.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def __init__(
Severity: Minor
Found in il2fb/commons/air_forces.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

        return value
    Severity: Major
    Found in il2fb/commons/structures.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return type_(value)
      Severity: Major
      Found in il2fb/commons/structures.py - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language