IT61/it61-rails

View on GitHub

Showing 24 of 24 total issues

Function easeOutQuad has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    easeOutQuad: function (x, t, b, c, d) {
Severity: Minor
Found in app/assets/javascripts/components/dropdown.js - About 35 mins to fix

    Function showImageOnLoad has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function showImageOnLoad($imageInput, $image, onLoadCallback) {
      if (!$imageInput) {
        return;
      }
    
    
    Severity: Minor
    Found in app/assets/javascripts/image_show.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_user_from_omniauth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_user_from_omniauth(_kind)
          auth = request.env["omniauth.auth"]
    
          @user = User.from_omniauth!(auth)
    
    
    Severity: Minor
    Found in app/controllers/users/omniauth_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_photos has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def load_photos(_tag)
        photos ||= InstagramCache.get(_tag)
        if photos.blank?
          photos = load_from_instagram(_tag)
          InstagramCache.store(_tag, photos) unless photos.blank?
    Severity: Minor
    Found in lib/instagram_service.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language