IdentityPython/pyFF

View on GitHub

Showing 451 of 451 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def guess_entity_software(e):
    for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                     e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
        location = elt.get('Location')
        if location:
Severity: Major
Found in src/pyff/utils.py and 1 other location - About 4 days to fix
src/pyff/samlmd.py on lines 327..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 432.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def guess_entity_software(e):
    for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                     e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
        location = elt.get('Location')
        if location:
Severity: Major
Found in src/pyff/samlmd.py and 1 other location - About 4 days to fix
src/pyff/utils.py on lines 524..576

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 432.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File builtins.py has 1026 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Package that contains the basic set of pipes - functions that can be used to put together a processing pipeling
for pyFF.
"""

import base64
Severity: Major
Found in src/pyff/builtins.py - About 2 days to fix

    File samlmd.py has 812 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from datetime import datetime
    from .utils import parse_xml, check_signature, root, validate_document, xml_error, \
        schema, iso2datetime, duration2timedelta, filter_lang, url2host, trunc_str, subdomains, \
        has_tag, hash_id, load_callable, rreplace, dumptree, first_text, url_get, img_to_data
    from .logs import get_log
    Severity: Major
    Found in src/pyff/samlmd.py - About 1 day to fix

      Function request has a Cognitive Complexity of 89 (exceeds 5 allowed). Consider refactoring.
      Open

          def request(self, **kwargs):
              """The main request processor. This code implements all rendering of metadata.
              """
      
              if not self.ready:
      Severity: Minor
      Found in src/pyff/mdx.py - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File mdx.py has 727 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """
      An implementation of draft-lajoie-md-query
      
      .. code-block:: bash
      
      
      Severity: Major
      Found in src/pyff/mdx.py - About 1 day to fix

        File store.py has 587 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        from six import StringIO
        from copy import deepcopy
        import re
        from redis import Redis
        from .constants import NS, ATTRS, ATTRS_INV
        Severity: Major
        Found in src/pyff/store.py - About 1 day to fix

          Function search has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
          Open

              def search(self, query=None, path=None, page=None, page_limit=10, entity_filter=None, related=None):
                  """
          :param query: A string to search for.
          :param path: The repository collection (@Name) to search in - None for search in all collections
          :param page:  When using paged search, the page index
          Severity: Minor
          Found in src/pyff/store.py - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if len(args) > 0 and args[0] in self.server.aliases:
                      kwargs['pfx'] = args[0]
                      if len(args) > 1:
                          kwargs['path'] = args[1]
                      return self.server.request(**kwargs)
          Severity: Major
          Found in src/pyff/mdx.py and 1 other location - About 1 day to fix
          src/pyff/mdx.py on lines 425..433

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 140.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if len(args) > 0 and args[0] in self.server.aliases:
                      kwargs['pfx'] = args[0]
                      if len(args) > 1:
                          kwargs['path'] = args[1]
                      return self.server.request(**kwargs)
          Severity: Major
          Found in src/pyff/mdx.py and 1 other location - About 1 day to fix
          src/pyff/mdx.py on lines 263..271

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 140.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function main has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
          Open

          def main():
              """
              The main entrypoint for the pyffd command.
              """
              try:
          Severity: Minor
          Found in src/pyff/mdx.py - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Cyclomatic complexity is too high in function main. (46)
          Open

          def main():
              """
              The main entrypoint for the pyffd command.
              """
              try:
          Severity: Minor
          Found in src/pyff/mdx.py by radon

          Cyclomatic Complexity

          Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

          Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

          Construct Effect on CC Reasoning
          if +1 An if statement is a single decision.
          elif +1 The elif statement adds another decision.
          else +0 The else statement does not cause a new decision. The decision is at the if.
          for +1 There is a decision at the start of the loop.
          while +1 There is a decision at the while statement.
          except +1 Each except branch adds a new conditional path of execution.
          finally +0 The finally block is unconditionally executed.
          with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
          assert +1 The assert statement internally roughly equals a conditional statement.
          Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
          Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

          Source: http://radon.readthedocs.org/en/latest/intro.html

          Function guess_entity_software has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
          Open

          def guess_entity_software(e):
              for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                               e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                  location = elt.get('Location')
                  if location:
          Severity: Minor
          Found in src/pyff/samlmd.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function guess_entity_software has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
          Open

          def guess_entity_software(e):
              for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                               e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                  location = elt.get('Location')
                  if location:
          Severity: Minor
          Found in src/pyff/utils.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File utils.py has 467 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # coding=utf-8
          from __future__ import print_function, unicode_literals, absolute_import
          
          """
          
          
          Severity: Minor
          Found in src/pyff/utils.py - About 7 hrs to fix

            Function hex_sha1 has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
            Open

            var hex_sha1 = function () {
            var fromCharCode = String.fromCharCode;
            /*
             * Calculate the SHA1 of a raw string
             */
            Severity: Minor
            Found in src/pyff/site/static/js/sha1.js - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if xp is None:
                        return l
                    else:
                        log.debug("filtering %d entities using xpath %s" % (len(l), xp))
                        t = entitiesdescriptor(l, 'dummy', lookup_fn=self.lookup)
            Severity: Major
            Found in src/pyff/store.py and 1 other location - About 6 hrs to fix
            src/pyff/samlmd.py on lines 1024..1033

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if xp is None:
                        return l
                    else:
                        log.debug("filtering %d entities using xpath %s" % (len(l), xp))
                        t = entitiesdescriptor(l, 'dummy', lookup_fn=self.lookup)
            Severity: Major
            Found in src/pyff/samlmd.py and 1 other location - About 6 hrs to fix
            src/pyff/store.py on lines 106..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Cyclomatic complexity is too high in function guess_entity_software. (35)
            Open

            def guess_entity_software(e):
                for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                                 e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                    location = elt.get('Location')
                    if location:
            Severity: Minor
            Found in src/pyff/samlmd.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            Cyclomatic complexity is too high in function guess_entity_software. (35)
            Open

            def guess_entity_software(e):
                for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                                 e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                    location = elt.get('Location')
                    if location:
            Severity: Minor
            Found in src/pyff/utils.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            Severity
            Category
            Status
            Source
            Language