IdentityPython/pyFF

View on GitHub

Showing 150 of 257 total issues

File builtins.py has 1356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
These are the built-in "pipes" - functions that can be used to put together a processing pipeling for pyFF.
"""

import base64
Severity: Major
Found in src/pyff/builtins.py - About 3 days to fix

    File samlmd.py has 1091 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import traceback
    from copy import deepcopy
    from datetime import datetime, timedelta, timezone
    from str2bool import str2bool
    from io import BytesIO
    Severity: Major
    Found in src/pyff/samlmd.py - About 2 days to fix

      File store.py has 776 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import json
      import operator
      import os
      import re
      import shutil
      Severity: Major
      Found in src/pyff/store.py - About 1 day to fix

        File utils.py has 732 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # coding=utf-8
        
        
        """
        
        
        Severity: Major
        Found in src/pyff/utils.py - About 1 day to fix

          Function guess_entity_software has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
          Open

          def guess_entity_software(e):
              for elt in chain(
                  e.findall(".//{%s}SingleSignOnService" % NS['md']), e.findall(".//{%s}AssertionConsumerService" % NS['md'])
              ):
                  location = elt.get('Location')
          Severity: Minor
          Found in src/pyff/utils.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function guess_entity_software has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
          Open

          def guess_entity_software(e):
              for elt in chain(
                  e.findall(".//{%s}SingleSignOnService" % NS['md']), e.findall(".//{%s}AssertionConsumerService" % NS['md'])
              ):
                  location = elt.get('Location')
          Severity: Minor
          Found in src/pyff/samlmd.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function search has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
          Open

              def search(self, query=None, path=None, entity_filter=None, related=None):
                  """
                  :param query: A string to search for.
                  :param path: The repository collection (@Name) to search in - None for search in all collections
                  :param entity_filter: An optional lookup expression used to filter the entries before search is done.
          Severity: Minor
          Found in src/pyff/store.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function select has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
          Open

          def select(req: Plumbing.Request, *opts):
              """
              Select a set of EntityDescriptor elements as the working document.
          
              :param req: The request
          Severity: Minor
          Found in src/pyff/builtins.py - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function process_handler has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
          Open

          def process_handler(request: Request) -> Response:
              """
              The main request handler for pyFF. Implements API call hooks and content negotiation.
          
              :param request: the HTTP request object
          Severity: Minor
          Found in src/pyff/api.py - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File constants.py has 432 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          """
          Useful constants for pyFF. Mostly XML namespace declarations.
          """
          
          import getopt
          Severity: Minor
          Found in src/pyff/constants.py - About 6 hrs to fix

            File api.py has 431 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import importlib
            import threading
            from datetime import datetime, timedelta
            from json import dumps
            from typing import Any, Dict, Generator, Iterable, List, Mapping, Optional, Tuple
            Severity: Minor
            Found in src/pyff/api.py - About 6 hrs to fix

              Function parse has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
              Open

                  def parse(self, resource: Resource, content: str) -> EidasMDParserInfo:
                      info = EidasMDParserInfo(description='eIDAS MetadataServiceList', expiration_time='None')
                      t = parse_xml(unicode_stream(content))
                      if config.xinclude:
                          t.xinclude()
              Severity: Minor
              Found in src/pyff/samlmd.py - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File resource.py has 403 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              """
              
              An abstraction layer for metadata fetchers. Supports both synchronous and asynchronous fetchers with cache.
              
              """
              Severity: Minor
              Found in src/pyff/resource.py - About 5 hrs to fix

                Function finalize has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                Open

                def finalize(req: Plumbing.Request, *opts):
                    """
                    Prepares the working document for publication/rendering.
                
                    :param req: The request
                Severity: Minor
                Found in src/pyff/builtins.py - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function discojson_sp has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                Open

                def discojson_sp(e, global_trust_info=None, global_md_sources=None):
                    sp = {}
                
                    tinfo_el = e.find('.//{%s}TrustInfo' % NS['ti'])
                    if tinfo_el is None:
                Severity: Minor
                Found in src/pyff/samlmd.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function certreport has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                Open

                def certreport(req: Plumbing.Request, *opts):
                    """
                    Generate a report of the certificates (optionally limited by expiration time or key size) found in the selection.
                
                    :param req: The request
                Severity: Minor
                Found in src/pyff/builtins.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function acquireWrite has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                Open

                    def acquireWrite(self, timeout=None):
                        """Acquire a write lock for the current thread, waiting at most timeout seconds or doing a non-blocking
                            check in case timeout is <= 0.
                
                        * In case the write lock cannot be serviced due to the deadlock condition mentioned above, a ValueError is raised.
                Severity: Minor
                Found in src/pyff/locks.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function publish has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                def publish(req: Plumbing.Request, *opts):
                    """
                    Publish the working document in XML form.
                
                    :param req: The request
                Severity: Minor
                Found in src/pyff/builtins.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parse_options has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                Open

                def parse_options(program, docs):
                    (short_args, long_args) = config.args(program)
                    docs += config.help(program)
                    try:
                        opts, args = getopt.getopt(sys.argv[1:], short_args, long_args)
                Severity: Minor
                Found in src/pyff/constants.py - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parse has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    def parse(self, getter: Callable[[str], Response]) -> Deque[Resource]:
                        data, status, info = self.load_resource(getter)
                
                        if not data:
                            raise ResourceException(f'Nothing to parse when loading resource {self}')
                Severity: Minor
                Found in src/pyff/resource.py - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language