IdentityPython/pyFF

View on GitHub
src/pyff/resource.py

Summary

Maintainability
C
1 day
Test Coverage

Cyclomatic complexity is too high in method parse. (12)
Open

    def parse(self, getter):
        info = dict()
        info['Resource'] = self.url
        self.add_info(info)
        data = None
Severity: Minor
Found in src/pyff/resource.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function parse has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def parse(self, getter):
        info = dict()
        info['Resource'] = self.url
        self.add_info(info)
        data = None
Severity: Minor
Found in src/pyff/resource.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Resource has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Resource(Watchable):
    def __init__(self, url=None, **kwargs):
        super().__init__()
        self.url = url
        self.opts = kwargs
Severity: Minor
Found in src/pyff/resource.py - About 2 hrs to fix

    Cyclomatic complexity is too high in method _setup. (8)
    Open

        def _setup(self):
            self.opts.setdefault('cleanup', [])
            self.opts.setdefault('via', [])
            self.opts.setdefault('fail_on_error', False)
            self.opts.setdefault('verify', None)
    Severity: Minor
    Found in src/pyff/resource.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function _setup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _setup(self):
            self.opts.setdefault('cleanup', [])
            self.opts.setdefault('via', [])
            self.opts.setdefault('fail_on_error', False)
            self.opts.setdefault('verify', None)
    Severity: Minor
    Found in src/pyff/resource.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def i_handle(self, t, url=None, response=None, exception=None, last_fetched=None):
    Severity: Minor
    Found in src/pyff/resource.py - About 35 mins to fix

      Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __call__(self, watched=None, url=None, response=None, exception=None, last_fetched=None):
      Severity: Minor
      Found in src/pyff/resource.py - About 35 mins to fix

        Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def i_handle(self, t, url=None, response=None, exception=None, last_fetched=None):
        Severity: Minor
        Found in src/pyff/resource.py - About 35 mins to fix

          Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def i_handle(self, t, url=None, response=None, exception=None, last_fetched=None):
          Severity: Minor
          Found in src/pyff/resource.py - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status