IdentityPython/pyFF

View on GitHub
src/pyff/site/static/js/jquery-ds-widget.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function _update has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _update: function () {
            var obj = this;
            obj.discovery_service_storage_url = obj.options['discovery_service_storage_url'] || obj.element.attr('data-store');
            obj.sp_entity_id = obj.options['sp_entity_id'] || obj.element.attr('data-href');
            obj.discovery_service_search_url = obj.options['discovery_service_search_url'] || obj.element.attr('data-search');
Severity: Major
Found in src/pyff/site/static/js/jquery-ds-widget.js - About 2 hrs to fix

    Function _create has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _create: function () {
                var obj = this;
                if (typeof obj.options['render'] !== 'function') {
                    obj._template_with_icon = Hogan.compile('<div data-href="{{entity_id}}" class="identityprovider list-group-item">' +
                        '{{^sticky}}<button type="button" alt="{{ _(\"Remove from list\") }}" data-toggle="tooltip" data-placement="left" class="close">&times;</button>{{/sticky}}' +
    Severity: Minor
    Found in src/pyff/site/static/js/jquery-ds-widget.js - About 1 hr to fix

      Function _after has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _after: function (count) {
                  var saved_choices_element = $(this.options['saved_choices_selector']);
                  if (this.discovery_service_search_url) {
                      var obj = this;
                      var search_result_element = $(obj.options['search_result_selector']);
      Severity: Minor
      Found in src/pyff/site/static/js/jquery-ds-widget.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (!$.isFunction(obj.options['render_search_result'])) {
                        obj.options['render_search_result'] = obj.options['render'];
                    }
        Severity: Minor
        Found in src/pyff/site/static/js/jquery-ds-widget.js and 1 other location - About 40 mins to fix
        src/pyff/site/static/js/jquery-ds-widget.js on lines 48..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (!$.isFunction(obj.options['render_saved_choice'])) {
                        obj.options['render_saved_choice'] = obj.options['render'];
                    }
        Severity: Minor
        Found in src/pyff/site/static/js/jquery-ds-widget.js and 1 other location - About 40 mins to fix
        src/pyff/site/static/js/jquery-ds-widget.js on lines 45..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status