Incredible0n3/ball_clock

View on GitHub

Showing 3 of 3 total issues

Method add_minute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.add_minute
    if @min_track.length < 4
      @min_track << @current_que.shift
    elsif @five_min_track.length < 11
      @five_min_track << @current_que.shift
Severity: Minor
Found in lib/clock.rb - About 1 hr to fix

    Method run_ball_clock has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.run_ball_clock(balls, run_time)
        @current_que = []
        @hours_passed = '0'.to_i
        @repeat = false
        min_left = run_time.to_i
    Severity: Minor
    Found in lib/clock.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_minute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.add_minute
        if @min_track.length < 4
          @min_track << @current_que.shift
        elsif @five_min_track.length < 11
          @five_min_track << @current_que.shift
    Severity: Minor
    Found in lib/clock.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language