Ink/filepicker-rails

View on GitHub

Showing 3 of 3 total issues

Method build_callbacks_js has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def build_callbacks_js(options)
      string = ""
      string << ", onOpen: data => #{options.delete(:onOpen)}(data)" unless options[:onOpen].blank?
      string << ", onClose: () => #{options.delete(:onClose)}()" unless options[:onClose].blank?
      string << ", onFileUploadFinished: data => #{options.delete(:onFileUploadFinished)}(data)" unless options[:onFileUploadFinished].blank?
Severity: Minor
Found in app/helpers/filestack_rails/application_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method picker has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def picker(client_name, api_key, options, callback, other_callbacks = nil)
Severity: Minor
Found in lib/filestack_rails/filestack_js.rb - About 35 mins to fix

    Method picker has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def picker(client_name, api_key, options, callback, other_callbacks = nil)
    Severity: Minor
    Found in lib/filestack_rails/filestack_js.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language