InterNACHI/modular

View on GitHub

Showing 8 of 13 total issues

File ModularServiceProvider.php has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace InterNACHI\Modular\Support;

use Closure;
Severity: Minor
Found in src/Support/ModularServiceProvider.php - About 3 hrs to fix

    ModularServiceProvider has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ModularServiceProvider extends ServiceProvider
    {
        /**
         * @var \InterNACHI\Modular\Support\ModuleRegistry
         */
    Severity: Minor
    Found in src/Support/ModularServiceProvider.php - About 2 hrs to fix

      Method updateCoreComposerConfig has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function updateCoreComposerConfig()
          {
              $this->title('Updating application composer.json file');
              
              // We're going to move into the Laravel base directory while
      Severity: Minor
      Found in src/Console/Commands/Make/MakeModule.php - About 1 hr to fix

        Method writeStubs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function writeStubs()
            {
                $this->title('Creating initial module files');
                
                $tests_base = config('app-modules.tests_base', 'Tests\TestCase');
        Severity: Minor
        Found in src/Console/Commands/Make/MakeModule.php - About 1 hr to fix

          Method createClass has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  protected function createClass($force = false, $inline = false)
                  {
                      if ($module = $this->module()) {
                          $name = Str::of($this->argument('name'))
                              ->split('/[.\/(\\\\)]+/')
          Severity: Minor
          Found in src/Console/Commands/Make/MakeLivewire.php - About 1 hr to fix

            Method write has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function write(): bool
                {
                    $modules_directory = config('app-modules.modules_directory', 'app-modules');
                    
                    $iml = $this->getNormalizedPluginConfig();
            Severity: Minor
            Found in src/Support/PhpStorm/ProjectImlWriter.php - About 1 hr to fix

              Function updateCoreComposerConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function updateCoreComposerConfig()
                  {
                      $this->title('Updating application composer.json file');
                      
                      // We're going to move into the Laravel base directory while
              Severity: Minor
              Found in src/Console/Commands/Make/MakeModule.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      protected function createClass($force = false, $inline = false)
                      {
                          if ($module = $this->module()) {
                              $name = Str::of($this->argument('name'))
                                  ->split('/[.\/(\\\\)]+/')
              Severity: Minor
              Found in src/Console/Commands/Make/MakeLivewire.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language