JASchilz/pystrike

View on GitHub

Showing 4 of 4 total issues

Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def update(self):
        """
        Update the charge from the server.

        If this charge has an `id`, then the method will _retrieve_ the
Severity: Minor
Found in pystrike/charge.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(
Severity: Minor
Found in pystrike/charge.py - About 35 mins to fix

    Function _make_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _make_request(self, method, path, body, headers, retry=True):
    Severity: Minor
    Found in pystrike/charge.py - About 35 mins to fix

      Function _make_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def _make_request(self, method, path, body, headers, retry=True):
      
              try:
                  self.api_connection.request(
                      method,
      Severity: Minor
      Found in pystrike/charge.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language