JEG2/highline

View on GitHub
lib/highline/question_asker.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method ask_once has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def ask_once
      # If in readline mode, let reline take care of the prompt
      question.show_question(@highline) unless question.readline

      begin
Severity: Minor
Found in lib/highline/question_asker.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ask_once has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def ask_once
      # If in readline mode, let reline take care of the prompt
      question.show_question(@highline) unless question.readline

      begin
Severity: Minor
Found in lib/highline/question_asker.rb - About 1 hr to fix

    Method gather_answers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def gather_answers
          verify_match = question.verify_match
          answers = []
    
          # when verify_match is set this loop will repeat until unique_answers == 1
    Severity: Minor
    Found in lib/highline/question_asker.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status