JS-Tech/resj

View on GitHub

Showing 8 of 14 total issues

Function mapLoaded has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  mapLoaded() {
    const map = this.map;

    map.addSource('items', {
      type: "geojson",
Severity: Major
Found in app/javascript/controllers/cards/list_controller.js - About 4 hrs to fix

    Function initialize has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      initialize() {
        const mapElement = this.mapTarget;
        if (!mapElement) {
          console.error("Mapbox HTML element not found.")
          return
    Severity: Major
    Found in app/javascript/controllers/cards/location_controller.js - About 4 hrs to fix

      Function initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initialize() {
          const mapElement = document.getElementById('mapbox');
      
          if (!mapElement) {
            console.error("mapbox html element not found")
      Severity: Minor
      Found in app/javascript/controllers/cards/list_controller.js - About 2 hrs to fix

        Function snapifyTable has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function snapifyTable(snaptable) {
        
          var tableButtons = snaptable.querySelector(".table_buttons"),
              editButton = tableButtons.querySelector("a.edit"),
              deleteButton = tableButtons.querySelector("a.delete"),
        Severity: Minor
        Found in app/javascript/admin/snaptable.js - About 1 hr to fix

          Function getBoundingBox has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            getBoundingBox(data) {
              var bounds = {}, coords, point, latitude, longitude;
          
              for (var i = 0; i < data.length; i++) {
                coords = data[i].geometry.coordinates;
          Severity: Minor
          Found in app/javascript/controllers/cards/list_controller.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function submit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            async submit() {
              const formData = new FormData(this.formTarget);
              formData.append("card[current_step]", this.data.get("step"));
              try {
                const res = await fetch(this.formTarget.getAttribute("action"), { method: "PATCH", body: formData });
          Severity: Minor
          Found in app/javascript/controllers/cards/form_controller.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_with_password has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def update_with_password(current_password, params)
              authenticated = authenticate(current_password)
              assign_attributes(params)
              if valid? && authenticated
                save
          Severity: Minor
          Found in app/models/user.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
              @orator = Orator.new(orator_params)
              @orator.user = current_user if signed_in?
              if @orator.save
                UserMailer.confirmation(@orator.user).deliver_now unless signed_in?
          Severity: Minor
          Found in app/controllers/orators_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language