JamieMason/self-help

View on GitHub

Showing 11 of 11 total issues

File rxjs-operator-decision-tree.ts has 655 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Branch, Node } from '..';

const withRandomDelay = (children: Node[]) => (): Promise<Node[]> =>
  new Promise((resolve) =>
    setTimeout(() => resolve(children), (Math.floor(Math.random() * 5) + 1) * 1000),
Severity: Major
Found in src/fixtures/rxjs-operator-decision-tree.ts - About 1 day to fix

    Function createTreeMachine has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const createTreeMachine = (rootNode: Node, id: string = 'tree-machine'): TreeMachine => {
      const RENDER_BRANCH = `#${id}.renderBranch`;
      const RENDER_LEAF = `#${id}.renderLeaf`;
      const RENDER_VALUE = `#${id}.renderValue`;
      const RESOLVE_BRANCH = `#${id}.resolveBranch`;
    Severity: Major
    Found in src/machine/tree/index.ts - About 3 hrs to fix

      Function start has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const start = async (interpreter: TreeInterpreter): Promise<void> => {
        const renderChoice = (currentNode: Node) => {
          console.log(chalk.green('?'), chalk.bold(currentNode.label));
        };
      
      
      Severity: Minor
      Found in src/interactive.ts - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        if (program.source && isString(program.source)) {
          run({ sourcePath: program.source });
        } else {
          program.outputHelp();
          process.exit(1);
        Severity: Major
        Found in src/bin-interactive.ts and 1 other location - About 1 hr to fix
        src/bin-markdown.ts on lines 12..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        if (program.source && isString(program.source)) {
          run({ sourcePath: program.source });
        } else {
          program.outputHelp();
          process.exit(1);
        Severity: Major
        Found in src/bin-markdown.ts and 1 other location - About 1 hr to fix
        src/bin-interactive.ts on lines 12..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                      label: 'if they are at the start of the Observable',
                      children: [
                        {
                          label: 'and only the first value',
        Severity: Major
        Found in src/fixtures/rxjs-operator-decision-tree.ts and 3 other locations - About 40 mins to fix
        src/fixtures/rxjs-operator-decision-tree.ts on lines 185..202
        src/fixtures/rxjs-operator-decision-tree.ts on lines 509..526
        src/fixtures/rxjs-operator-decision-tree.ts on lines 608..624

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                {
                  label: 'I want to compute a formula using all values emitted',
                  children: [
                    {
                      label: 'and only output the final computed value',
        Severity: Major
        Found in src/fixtures/rxjs-operator-decision-tree.ts and 3 other locations - About 40 mins to fix
        src/fixtures/rxjs-operator-decision-tree.ts on lines 42..58
        src/fixtures/rxjs-operator-decision-tree.ts on lines 509..526
        src/fixtures/rxjs-operator-decision-tree.ts on lines 608..624

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                      label: 'that iterates',
                      children: [
                        {
                          label: 'over the values in an array',
        Severity: Major
        Found in src/fixtures/rxjs-operator-decision-tree.ts and 3 other locations - About 40 mins to fix
        src/fixtures/rxjs-operator-decision-tree.ts on lines 42..58
        src/fixtures/rxjs-operator-decision-tree.ts on lines 185..202
        src/fixtures/rxjs-operator-decision-tree.ts on lines 509..526

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                      label: 'I want to output a value computed from values of the source Observables',
                      children: [
                        {
                          label: 'using the latest value of each source whenever any source emits',
        Severity: Major
        Found in src/fixtures/rxjs-operator-decision-tree.ts and 3 other locations - About 40 mins to fix
        src/fixtures/rxjs-operator-decision-tree.ts on lines 42..58
        src/fixtures/rxjs-operator-decision-tree.ts on lines 185..202
        src/fixtures/rxjs-operator-decision-tree.ts on lines 608..624

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const isBranch = (value: any): value is Branch =>
          hasLabel(value) && isChildren(children(value));
        Severity: Minor
        Found in src/machine/tree/nodes.ts and 1 other location - About 35 mins to fix
        src/machine/tree/nodes.ts on lines 17..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const isAsyncBranch = (value: any): value is AsyncBranch =>
          hasLabel(value) && isFunction(children(value));
        Severity: Minor
        Found in src/machine/tree/nodes.ts and 1 other location - About 35 mins to fix
        src/machine/tree/nodes.ts on lines 14..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language