JamieMason/syncpack

View on GitHub
test/scenarios/create-scenario.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function createScenario has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Severity: Major
Found in test/scenarios/create-scenario.ts - About 2 hrs to fix

    Function mockedFiles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Severity: Minor
    Found in test/scenarios/create-scenario.ts - About 1 hr to fix

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      Type assertion on object literals is forbidden, use a type annotation instead.
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-object-literal-type-assertion

      Forbids an object literal to appear in a type assertion expression. Casting to any or to unknown is still allowed.

      Rationale

      Always prefer const x: T = { ... }; to const x = { ... } as T;. The type assertion in the latter case is either unnecessary or hides an error. The compiler will warn for excess properties with this syntax, but not missing required fields. For example: const x: { foo: number } = {} will fail to compile, but const x = {} as { foo: number } will succeed. Additionally, the const assertion const x = { foo: 1 } as const, introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.

      Notes
      • TypeScript Only

      Config

      One option may be configured:

      • allow-arguments allows type assertions to be used on object literals inside call expressions.
      Examples
      "no-object-literal-type-assertion": true
      "no-object-literal-type-assertion": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "allow-arguments": {
            "type": "boolean"
          }
        },
        "additionalProperties": false
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "allow-fast-null-checks",
            "allow-new",
            "allow-tagged-template"
          ]
        },
        "minLength": 0,
        "maxLength": 3
      }

      For more information see this page.

      Missing semicolon
      Open

      Severity: Minor
      Found in test/scenarios/create-scenario.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "always",
              "never"
            ]
          },
          {
            "type": "string",
            "enum": [
              "ignore-interfaces"
            ]
          }
        ],
        "additionalItems": false
      }

      For more information see this page.

      There are no issues that match your filters.

      Category
      Status