Jelle-S/TheSportsDb

View on GitHub

Showing 92 of 92 total issues

Method initPropertyMapDefinition has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected static function initPropertyMapDefinition() {
    static::$propertyMapDefinition
      ->addPropertyMap(
        new PropertyDefinition('idEvent'),
        new PropertyDefinition('id')
Severity: Major
Found in src/Entity/Event.php - About 7 hrs to fix

    Event has 51 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Event extends Entity implements EventInterface {
    
      /**
       * {@inheritdoc}
       */
    Severity: Major
    Found in src/Entity/Event.php - About 7 hrs to fix

      EventProxy has 45 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class EventProxy extends Proxy implements EventInterface {
      
        /**
         * {@inheritdoc}
         */
      Severity: Minor
      Found in src/Entity/Proxy/EventProxy.php - About 6 hrs to fix

        File Event.php has 395 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * @file
         * Contains \TheSportsDb\Entity\Event.
         */
        Severity: Minor
        Found in src/Entity/Event.php - About 5 hrs to fix

          Method initPropertyMapDefinition has 121 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            protected static function initPropertyMapDefinition() {
              static::$propertyMapDefinition
                ->addPropertyMap(
                  new PropertyDefinition('idTeam'),
                  new PropertyDefinition('id')
          Severity: Major
          Found in src/Entity/Team.php - About 4 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
            /**
             * @file
             * Contains \TheSportsDb\Entity\Repository\PlayerRepository.
             */
            Severity: Major
            Found in src/Entity/Repository/PlayerRepository.php and 1 other location - About 4 hrs to fix
            src/Entity/Repository/TeamRepository.php on lines 1..49

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 174.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
            /**
             * @file
             * Contains \TheSportsDb\Entity\Repository\TeamRepository.
             */
            Severity: Major
            Found in src/Entity/Repository/TeamRepository.php and 1 other location - About 4 hrs to fix
            src/Entity/Repository/PlayerRepository.php on lines 1..49

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 174.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method initPropertyMapDefinition has 101 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              protected static function initPropertyMapDefinition() {
                static::$propertyMapDefinition
                  ->addPropertyMap(
                    new PropertyDefinition('idPlayer'),
                    new PropertyDefinition('id')
            Severity: Major
            Found in src/Entity/Player.php - About 4 hrs to fix

              Team has 32 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Team extends Entity implements TeamInterface {
              
                /**
                 * {@inheritdoc}
                 */
              Severity: Minor
              Found in src/Entity/Team.php - About 4 hrs to fix

                TheSportsDb has 31 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class TheSportsDb implements EntityManagerConsumerInterface {
                
                  use EntityManagerConsumerTrait;
                
                  /**
                Severity: Minor
                Found in src/TheSportsDb.php - About 3 hrs to fix

                  Method initPropertyMapDefinition has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    protected static function initPropertyMapDefinition() {
                      static::$propertyMapDefinition
                        ->addPropertyMap(
                          new PropertyDefinition('idLeague'),
                          new PropertyDefinition('id')
                  Severity: Major
                  Found in src/Entity/League.php - About 3 hrs to fix

                    TeamProxy has 30 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class TeamProxy extends Proxy implements TeamInterface {
                    
                      /**
                       * {@inheritdoc}
                       */
                    Severity: Minor
                    Found in src/Entity/Proxy/TeamProxy.php - About 3 hrs to fix

                      The class Event has an overall complexity of 53 which is very high. The configured complexity threshold is 50.
                      Open

                      class Event extends Entity implements EventInterface {
                      
                        /**
                         * {@inheritdoc}
                         */
                      Severity: Minor
                      Found in src/Entity/Event.php by phpmd

                      The class EventRepository has 11 public methods. Consider refactoring EventRepository to keep number of public methods under 10.
                      Open

                      class EventRepository extends Repository implements EventRepositoryInterface {
                      
                        /**
                         * {@inheritdoc}
                         */

                      TooManyPublicMethods

                      Since: 0.1

                      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

                      By default it ignores methods starting with 'get' or 'set'.

                      Example

                      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

                      The class Entity has 12 public methods. Consider refactoring Entity to keep number of public methods under 10.
                      Open

                      abstract class Entity implements EntityInterface {
                      
                        /**
                         * The property map definition.
                         *
                      Severity: Minor
                      Found in src/Entity/Entity.php by phpmd

                      TooManyPublicMethods

                      Since: 0.1

                      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

                      By default it ignores methods starting with 'get' or 'set'.

                      Example

                      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

                      Player has 26 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Player extends Entity implements PlayerInterface {
                      
                        /**
                         * {@inheritdoc}
                         */
                      Severity: Minor
                      Found in src/Entity/Player.php - About 3 hrs to fix

                        League has 25 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class League extends Entity implements LeagueInterface {
                        
                          /**
                           * {@inheritdoc}
                           */
                        Severity: Minor
                        Found in src/Entity/League.php - About 2 hrs to fix

                          PlayerProxy has 24 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class PlayerProxy extends Proxy implements PlayerInterface {
                          
                            /**
                             * {@inheritdoc}
                             */
                          Severity: Minor
                          Found in src/Entity/Proxy/PlayerProxy.php - About 2 hrs to fix

                            LeagueProxy has 24 functions (exceeds 20 allowed). Consider refactoring.
                            Open

                            class LeagueProxy extends Proxy implements LeagueInterface {
                            
                              /**
                               * {@inheritdoc}
                               */
                            Severity: Minor
                            Found in src/Entity/Proxy/LeagueProxy.php - About 2 hrs to fix

                              File Team.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              /**
                               * @file
                               * Contains \TheSportsDb\Entity\Team.
                               */
                              Severity: Minor
                              Found in src/Entity/Team.php - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language