Sign upLogin

Jelle-S/TheSportsDb

View on GitHub
Star

Showing 31 of 92 total issues

Method initPropertyMapDefinition has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected static function initPropertyMapDefinition() {
    static::$propertyMapDefinition
      ->addPropertyMap(
        new PropertyDefinition('idEvent'),
        new PropertyDefinition('id')
Severity: Major
Found in src/Entity/Event.php - About 7 hrs to fix

    Event has 51 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Event extends Entity implements EventInterface {

  /**
   * {@inheritdoc}
   */
    Severity: Major
    Found in src/Entity/Event.php - About 7 hrs to fix

      EventProxy has 45 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class EventProxy extends Proxy implements EventInterface {

  /**
   * {@inheritdoc}
   */
      Severity: Minor
      Found in src/Entity/Proxy/EventProxy.php - About 6 hrs to fix

        File Event.php has 395 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * @file
 * Contains \TheSportsDb\Entity\Event.
 */
        Severity: Minor
        Found in src/Entity/Event.php - About 5 hrs to fix

          Method initPropertyMapDefinition has 121 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            protected static function initPropertyMapDefinition() {
    static::$propertyMapDefinition
      ->addPropertyMap(
        new PropertyDefinition('idTeam'),
        new PropertyDefinition('id')
          Severity: Major
          Found in src/Entity/Team.php - About 4 hrs to fix

            Method initPropertyMapDefinition has 101 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              protected static function initPropertyMapDefinition() {
    static::$propertyMapDefinition
      ->addPropertyMap(
        new PropertyDefinition('idPlayer'),
        new PropertyDefinition('id')
            Severity: Major
            Found in src/Entity/Player.php - About 4 hrs to fix

              Team has 32 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Team extends Entity implements TeamInterface {

  /**
   * {@inheritdoc}
   */
              Severity: Minor
              Found in src/Entity/Team.php - About 4 hrs to fix

                TheSportsDb has 31 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class TheSportsDb implements EntityManagerConsumerInterface {

  use EntityManagerConsumerTrait;

  /**
                Severity: Minor
                Found in src/TheSportsDb.php - About 3 hrs to fix

                  Method initPropertyMapDefinition has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    protected static function initPropertyMapDefinition() {
    static::$propertyMapDefinition
      ->addPropertyMap(
        new PropertyDefinition('idLeague'),
        new PropertyDefinition('id')
                  Severity: Major
                  Found in src/Entity/League.php - About 3 hrs to fix

                    TeamProxy has 30 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class TeamProxy extends Proxy implements TeamInterface {

  /**
   * {@inheritdoc}
   */
                    Severity: Minor
                    Found in src/Entity/Proxy/TeamProxy.php - About 3 hrs to fix

                      The class Entity has 12 public methods. Consider refactoring Entity to keep number of public methods under 10.
                      Open

                      abstract class Entity implements EntityInterface {

  /**
   * The property map definition.
   *
                      Severity: Minor
                      Found in src/Entity/Entity.php by phpmd

                      TooManyPublicMethods

                      Since: 0.1

                      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

                      By default it ignores methods starting with 'get' or 'set'.

                      Example

                      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

                      The class Event has an overall complexity of 53 which is very high. The configured complexity threshold is 50.
                      Open

                      class Event extends Entity implements EventInterface {

  /**
   * {@inheritdoc}
   */
                      Severity: Minor
                      Found in src/Entity/Event.php by phpmd

                      The class EventRepository has 11 public methods. Consider refactoring EventRepository to keep number of public methods under 10.
                      Open

                      class EventRepository extends Repository implements EventRepositoryInterface {

  /**
   * {@inheritdoc}
   */
                      Severity: Minor
                      Found in src/Entity/Repository/EventRepository.php by phpmd

                      TooManyPublicMethods

                      Since: 0.1

                      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

                      By default it ignores methods starting with 'get' or 'set'.

                      Example

                      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

                      Player has 26 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Player extends Entity implements PlayerInterface {

  /**
   * {@inheritdoc}
   */
                      Severity: Minor
                      Found in src/Entity/Player.php - About 3 hrs to fix

                        League has 25 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class League extends Entity implements LeagueInterface {

  /**
   * {@inheritdoc}
   */
                        Severity: Minor
                        Found in src/Entity/League.php - About 2 hrs to fix

                          LeagueProxy has 24 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class LeagueProxy extends Proxy implements LeagueInterface {

  /**
   * {@inheritdoc}
   */
                          Severity: Minor
                          Found in src/Entity/Proxy/LeagueProxy.php - About 2 hrs to fix

                            PlayerProxy has 24 functions (exceeds 20 allowed). Consider refactoring.
                            Open

                            class PlayerProxy extends Proxy implements PlayerInterface {

  /**
   * {@inheritdoc}
   */
                            Severity: Minor
                            Found in src/Entity/Proxy/PlayerProxy.php - About 2 hrs to fix

                              File Team.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
/**
 * @file
 * Contains \TheSportsDb\Entity\Team.
 */
                              Severity: Minor
                              Found in src/Entity/Team.php - About 2 hrs to fix

                                Function sanitizeProperty has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  public function sanitizeProperty(\stdClass &$object, FactoryContainerInterface $factoryContainer) {
    if (($entityType = $this->getEntityType()) && isset($object->{$this->getName()})) {
      $value = &$object->{$this->getName()};
      if ($this->isArray()) {
        foreach ($value as &$val) {
                                Severity: Minor
                                Found in src/PropertyMapper/PropertyDefinition.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                The class Event has 50 public methods and attributes. Consider reducing the number of public items to less than 50.
                                Open

                                class Event extends Entity implements EventInterface {

  /**
   * {@inheritdoc}
   */
                                Severity: Minor
                                Found in src/Entity/Event.php by phpmd

                                ExcessivePublicCount

                                Since: 0.1

                                A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

                                Example

                                public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

                                Source https://phpmd.org/rules/codesize.html#excessivepubliccount

                                Severity
                                Category
                                Status
                                Source
                                Language