Jelle-S/arraykeycombiner

View on GitHub

Showing 3 of 3 total issues

Function combineIdentical has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  protected function combineIdentical($arrays) {
    // Check for identical items in the array and merge them.
    foreach ($arrays as &$sort) {
      asort($sort);
    }
Severity: Minor
Found in src/ArrayKeyCombiner.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function combineIntersections has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  protected function combineIntersections(&$arrays, $intersections) {
    $changed = FALSE;
    foreach ($intersections as $intersection) {
      $size = count($intersection);
      $keys = [];
Severity: Minor
Found in src/ArrayKeyCombiner.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using Jelle_S\Util\Combiner\count() function in do loops.
Open

    do {
      $i = new ArrayIntersections($arrays, $this->threshold, $this->intersectionIterationsLimit);
      $intersections = $i->getAll();
      if (!$intersections) {
        break;
Severity: Minor
Found in src/ArrayKeyCombiner.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Severity
Category
Status
Source
Language