Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Aerial/Source/Models/Cache/VideoLoader.swift

Summary

Maintainability
C
7 hrs
Test Coverage

Function connection has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    func connection(_ connection: NSURLConnection, didReceive data: Data) {

        queue.async { () -> Void in
            self.fillInContentInformation(self.loadingRequest)
Severity: Minor
Found in Aerial/Source/Models/Cache/VideoLoader.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function connection has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func connection(_ connection: NSURLConnection, didReceive data: Data) {

        queue.async { () -> Void in
            self.fillInContentInformation(self.loadingRequest)
Severity: Minor
Found in Aerial/Source/Models/Cache/VideoLoader.swift - About 1 hr to fix

    Force casts should be avoided
    Open

            let httpResponse = response as! HTTPURLResponse
    Severity: Minor
    Found in Aerial/Source/Models/Cache/VideoLoader.swift by tailor

    forced-type-cast

    Avoid using the forced form of the type cast operator (as!) because Swift is not able to determine at compile time if the type conversion will succeed. In the event of an unsuccessful conversion, a runtime error will be triggered. The conditional form of the type cast operator (as?) is safer and should be used when possible.

    Preferred

    if let movie = item as? Movie {
    print("Movie: '\(movie.name)', dir. \(movie.director)")
}

    Not Preferred

    let movie = item as! Movie
print("Movie: '\(movie.name)', dir. \(movie.director)")

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        func startOffsetFromResponse(_ response: URLResponse) -> Int? {

        // get range response
        var regex: NSRegularExpression!
        do {
    Severity: Major
    Found in Aerial/Source/Models/Cache/VideoLoader.swift and 1 other location - About 3 hrs to fix
    Aerial/Source/Models/Cache/VideoDownload.swift on lines 289..320

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 240.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status